Skip to content

Conversation

@jiridanek
Copy link
Member

@jiridanek jiridanek commented Nov 12, 2025

Description

Automerge failed

We got pinged on slack

How Has This Been Tested?

Self checklist (all need to be checked):

  • Ensure that you have run make test (gmake on macOS) before asking for review
  • Changes to everything except Dockerfile.konflux files should be done in odh/notebooks and automatically synced to rhds/notebooks. For Konflux-specific changes, modify Dockerfile.konflux files directly in rhds/notebooks as these require special attention in the downstream repository and flow to the upcoming RHOAI release.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

harshad16 and others added 9 commits November 10, 2025 16:53
…ton-tag-2025b-v1.39

chore: update image tags 2025b-v1.38 → 2025b-v1.39
…hes (opendatahub-io#2664)

```bash
if command -v subscription-manager &> /dev/null; then
    echo "RHEL system detected. Running subscription-manager register."
    ...
else
    echo "Non-RHEL system detected. Skipping subscription-manager register."
fi
```
…dhat release key (opendatahub-io#2664)

When we update to latest AIPCC bases that don't remove the ``.repo` files, we will be able to remove the COPYs.

```
Red Hat Universal Base Image 9 (RPMs) - BaseOS  0.0  B/s |   0  B     00:00
  Curl error (37): Couldn't read a file:// file for file:///etc/pki/rpm-gpg/RPM-GPG-KEY-redhat-release [Couldn't open file /etc/pki/rpm-gpg/RPM-GPG-KEY-redhat-release]
```
Gateway API Compatibility: A Guide to Container Image Migration
@jiridanek
Copy link
Member Author

/build-konflux

@jiridanek jiridanek changed the title Rhds main Merge remote-tracking branch 'origin/main' into rhds-main Nov 12, 2025
Copy link
Member

@atheo89 atheo89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link

openshift-ci bot commented Nov 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atheo89

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Nov 12, 2025
@openshift-ci
Copy link

openshift-ci bot commented Nov 12, 2025

New changes are detected. LGTM label has been removed.

@jiridanek
Copy link
Member Author

I've added a commit to partially align the Dockerfiles, but it is not 100% yet

@jiridanek
Copy link
Member Author

/build-konflux

@openshift-ci
Copy link

openshift-ci bot commented Nov 12, 2025

@jiridanek: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images e98422e link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jiridanek jiridanek merged commit 6745e27 into red-hat-data-services:main Nov 12, 2025
24 of 74 checks passed
@jiridanek jiridanek deleted the rhds-main branch November 12, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants