-
Notifications
You must be signed in to change notification settings - Fork 24
Merge remote-tracking branch 'origin/main' into rhds-main #1688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Harshad Reddy Nalla <[email protected]>
…ton-tag-2025b-v1.39 chore: update image tags 2025b-v1.38 → 2025b-v1.39
…hes (opendatahub-io#2664) ```bash if command -v subscription-manager &> /dev/null; then echo "RHEL system detected. Running subscription-manager register." ... else echo "Non-RHEL system detected. Skipping subscription-manager register." fi ```
…dhat release key (opendatahub-io#2664) When we update to latest AIPCC bases that don't remove the ``.repo` files, we will be able to remove the COPYs. ``` Red Hat Universal Base Image 9 (RPMs) - BaseOS 0.0 B/s | 0 B 00:00 Curl error (37): Couldn't read a file:// file for file:///etc/pki/rpm-gpg/RPM-GPG-KEY-redhat-release [Couldn't open file /etc/pki/rpm-gpg/RPM-GPG-KEY-redhat-release] ```
Gateway API Compatibility: A Guide to Container Image Migration
…--extra-index-url` in all Dockerfiles (opendatahub-io#2667)
|
/build-konflux |
atheo89
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: atheo89 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
|
I've added a commit to partially align the Dockerfiles, but it is not 100% yet |
|
/build-konflux |
|
@jiridanek: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
Automerge failed
We got pinged on slack
How Has This Been Tested?
Self checklist (all need to be checked):
make test(gmakeon macOS) before asking for reviewDockerfile.konfluxfiles should be done inodh/notebooksand automatically synced torhds/notebooks. For Konflux-specific changes, modifyDockerfile.konfluxfiles directly inrhds/notebooksas these require special attention in the downstream repository and flow to the upcoming RHOAI release.Merge criteria: