Merge branch 'main' into rhds-main #1498
Conversation
…eam (opendatahub-io#1972) # Conflicts: # jupyter/pytorch+llmcompressor/ubi9-python-3.12/Pipfile.lock # jupyter/pytorch+llmcompressor/ubi9-python-3.12/requirements.txt
… other current cuda Dockerfiles (opendatahub-io#1972)
….yaml because we're not ready to release it yet
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
📋 Review Summary
This PR adds support for Python 3.12 to the pytorch+llmcompressor notebook and runtime images, while removing support for Python 3.11. The changes are well-structured and consistent with the project's standards for adding new Python versions.
🔍 General Feedback
- The transition from
micropipenvtouvfor package installation is a good improvement. - The addition of a test notebook for
llmcompressoris a welcome addition. - I've made a couple of minor suggestions to improve the consistency of the image labels in the Dockerfiles.
Overall, this is a solid contribution that expands the project's support for newer Python versions.
|
|
||
| ARG DATASCIENCE_SOURCE_CODE=jupyter/datascience/ubi9-python-3.11 | ||
| ARG PYTORCH_SOURCE_CODE=jupyter/pytorch+llmcompressor/ubi9-python-3.11 | ||
| ARG DATASCIENCE_SOURCE_CODE=jupyter/datascience/ubi9-python-3.12 |
There was a problem hiding this comment.
🟢 The summary and description labels should be updated to use "PyTorch LLM Compressor" for consistency with the name label and the imagestream definition.
| ARG DATASCIENCE_SOURCE_CODE=jupyter/datascience/ubi9-python-3.12 | |
| summary="Jupyter CUDA PyTorch LLM Compressor notebook image for ODH notebooks" \ | |
| description="Jupyter CUDA PyTorch LLM Compressor notebook image with base Python 3.12 builder image based on UBI9 for ODH notebooks" \ | |
| io.k8s.display-name="Jupyter CUDA PyTorch LLM Compressor notebook image for ODH notebooks" \ | |
| io.k8s.description="Jupyter CUDA PyTorch LLM Compressor notebook image with base Python 3.12 builder image based on UBI9 for ODH notebooks" \ |
2 participants
Description
How Has This Been Tested?
Merge criteria: