-
Notifications
You must be signed in to change notification settings - Fork 25
[rhoai-2.22] Update N-1 image references with the new builds and update manifest package information #1259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rhoai-2.22] Update N-1 image references with the new builds and update manifest package information #1259
Conversation
|
Validation complains about image related to increase. both increased by (100mb) |
|
I'll investigate the trustyai size increase, and then possibly also the other image |
|
For trustyai, the site-packages python directory got bigger |
|
/lgtm I believe this is not too concerning
The analysis reveals the following:
|
|
work out a detailed analysis plan for the other image, - odh-workbench-jupyter-pytorch-cuda-py311-ubi9-n-1=quay.io/modh/odh-pytorch-notebook@sha256:20f7ab8e7954106ea5e22f3ee0ba8bc7b03975e5735049a765e021aa7eb06861
+ odh-workbench-jupyter-pytorch-cuda-py311-ubi9-n-1=quay.io/modh/odh-pytorch-notebook@sha256:93f7c49aceb840662686bb13a0d33d7c3f4a38ed3926e332c28d87fa4ba6eae9Excellent. This corrected analysis is precise and provides the clear evidence needed. You've successfully navigated the investigation to its conclusion. Here is the final summary of the findings. ## Final Analysis: Package Size Breakdown 📊The detailed comparison of uncompressed package sizes pinpoints the exact contributors to the change.
The net change from just these four key packages is an increase of ## Uncompressed vs. Compressed SizeYou correctly noted that the final image size only changed by |
✦ cuSPARSELt is a high-performance library developed by NVIDIA for accelerating sparse matrix-matrix multiplication (SpMM) on modern NVIDIA GPUs. Here's a breakdown:
In short, it's a specialized tool that allows deep learning frameworks like PyTorch to perform calculations with sparse matrices much faster by using the dedicated Tensor Core hardware on NVIDIA GPUs. |
|
@atheo89 would you update the pr so the checks are passing please? I believe it is ok |
788120c to
866b592
Compare
866b592 to
61126f8
Compare
|
At some point the package validation test will fail with this error, it is expected: |
|
/approve it was only the expected one as it is mentioned above |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: atheo89 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
50486ca
into
red-hat-data-services:rhoai-2.22
…nv.sh` for PyTorch and TrustyAI environments Discussed in * red-hat-data-services#1259 (comment)
…nv.sh` for PyTorch and TrustyAI environments (#1293) Discussed in * #1259 (comment)
Related to: https://issues.redhat.com/browse/RHOAIENG-30247
This PR backports updates to the RHOAI 2.22 release branch.
Included changes: