Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for JMRD #256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Add support for JMRD #256
Changes from all commits
e6ae20127913d3a4f72fa762411fa0742a69a59b2ce7b52d4aa031db42f0946d2ee335f41e91818f3269c449a0c2c7fd70a23924c15d71b9845abebd6f37ff192759dFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about creating
parse_checked_knowledgelike others?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your suggestion. I agree with it and fixed with this commit f41e918.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the RBS for
Dialogue,utterances()is declared as non-nilArray[Utterance], but the class inherits fromStructand its initializer signature marksutterancesas optional. WithStruct’s positional initializer, omitting the last argument results inutterancesbeingnil, so the current type definition is inconsistent with runtime behavior. Consider either (1) makingutterancesnilable in both the accessor and initializer types, or (2) changing the Ruby implementation to ensureutterancesis always required (e.g., by not exposing the rawStructinitializer / using a custom initializer) so the non-nil type is accurate.Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.