Added support for the custom scrollParent
for the scrollIntoView
#197
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The
scrollIntoView
is great and convenient in most cases, especially if you need to scroll to the annotation on load of the page. Thanks!However, I our mobile app that uses

Ionic
components library, we faced an edge case with thegetScrollParent
. TheIonic
handles a scrollable content in a bit of a peculiar way. It uses#shadow-dom
to hide the "inner-scroll
" scrollable element, but its "public" elements all have theoverflow: visible
1Therefore, if we render the
text-annotator
over such content, thescrollIntoView
will be ineffective, operating over non-scrollable elements 🤷🏻♂️Changes Made
Added support for providing a custom
scrollParent
to overcome the sensible limitations of thegetScrollParent
.(Soomo Staged)
Footnotes
https://ionicframework.com/docs/api/content#scroll-methods ↩