markdown: parse fenced_code_attributes extension#445
Open
edwintorok wants to merge 1 commit intorealworldocaml:mainfrom
Open
markdown: parse fenced_code_attributes extension#445edwintorok wants to merge 1 commit intorealworldocaml:mainfrom
edwintorok wants to merge 1 commit intorealworldocaml:mainfrom
Conversation
Pandoc supports this extension: https://pandoc.org/MANUAL.html#extension-fenced_code_attributes ``` {#identifier .language attr="value"} ``` And this: ``` language {#identifier attr="value"} ``` Recognize them in the lexer. Try to limit the complexity of the regular expression by splitting off parsing of attributes into a separate 'parse' (otherwise we hit automata size limits in `ocamllex`). According to https://quarto.org/docs/authoring/markdown-basics.html#ordering-of-attributes the ordering has to be: * #identifiers * .classes * key-value attributes Signed-off-by: Edwin Török <edwin@etorok.net>
Contributor
Author
|
(this PR might need some wider testing to check it doesn't break backwards compatibility, is there a larger corpus you'd normally test changes like this on? e.g. the realworldocaml book, anything else?) |
Collaborator
|
Testing on RWO would indeed be a great idea - and checking that the resulting diff doesn't contain surprising results |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pandoc supports this extension: https://pandoc.org/MANUAL.html#extension-fenced_code_attributes
And this:
Recognize them in the lexer. Try to limit the complexity of the regular expression by splitting off parsing of attributes into a separate 'parse' (otherwise we hit automata size limits in
ocamllex).According to
https://quarto.org/docs/authoring/markdown-basics.html#ordering-of-attributes the ordering has to be:
For now on output we always normalize to this form (which isn't ideal, but could be improved later):
I initially tried to fully parse the attributes, but I've exceeded the maximum size of the
ocamllexautomaton, so I kept it simple in this PR (and do some minimal parsing in OCaml later, note that key-value pairs aren't split correctly, but when joined backed together they retain the original value).