APIv3: include readthedocs_yaml_path in Project serializer
#12566
+60
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return the `readthedocs_yaml_path` field in the Project serializer for APIv3 and allow setting it as well.
Member
Author
|
@copilot please write a simple test case for this PR to check that setting |
4 tasks
Contributor
- [x] Add `readthedocs_yaml_path` field to `ProjectSerializer` (read) - [x] Add `readthedocs_yaml_path` field to `ProjectUpdateSerializerBase` (write) - [x] Add test case `test_partial_update_project_readthedocs_yaml_path` to verify setting and getting the field via API - [x] Keep the comment about YAML config file settings <!-- START COPILOT CODING AGENT TIPS --> --- 💬 We'd love your input! Share your thoughts on Copilot coding agent in our [2 minute survey](https://gh.io/copilot-coding-agent-survey). --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: humitos <[email protected]>
humitos
commented
Dec 1, 2025
stsewd
reviewed
Dec 1, 2025
Member
stsewd
left a comment
stsewd
left a comment
There was a problem hiding this comment.
Documentation needs to be updated. We should also verify if validation is the same as one we do on the model and form.
Member
Author
|
I added the validation and update the docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return the
readthedocs_yaml_pathfield in the Project serializer for APIv3 and allow setting it as well.Requested by a user at https://app.frontapp.com/open/cnv_1i8d4tuq