Dashboard: don't prefetch latest build #12400
Open
+20
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsewd
commented
Aug 13, 2025
readthedocs/projects/models.py
Outdated
| @@ -1100,23 +1098,17 @@ def full_find(self, filename, version): | |||
| matches.append(os.path.join(root, match)) | |||
| return matches | |||
|
|
|||
| @lru_cache(maxsize=1) | |||
There was a problem hiding this comment.
this should also reduce the number of queries on .com, nothing like an old fashioned caching.
stsewd
commented
Aug 13, 2025
stsewd
added a commit
to readthedocs/ext-theme
that referenced
this pull request
Aug 13, 2025
|
Tests for the number of queries should pass after readthedocs/ext-theme#639 is merged |
humitos
approved these changes
Aug 14, 2025
| @@ -399,7 +399,7 @@ def test_dashboard_number_of_queries(self): | |||
| state=BUILD_STATE_FINISHED, | |||
| ) | |||
|
|
|||
| with self.assertNumQueries(12): | |||
| with self.assertNumQueries(27): | |||
There was a problem hiding this comment.
Maybe we want a note here explaining that more small fast queries here are better than a few slow ones.
| @@ -30,7 +30,7 @@ def get_context_data(self, **kwargs): | |||
|
|
|||
| # Show for the first few builds, return last build state | |||
| if project.builds.count() <= 5: | |||
| onboard["build"] = project.get_latest_build(finished=False) | |||
| onboard["build"] = project.latest_internal_build | |||
There was a problem hiding this comment.
It seems there is some change in behavior here. We were returning unfinished builds before, and now we are returning anyone. Is that expected?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_latest_build was doing something different than the prefetched value, looks like we never actually used this function with
finished=True, so I went ahead and renamed it and made it a property so we can cache it.