-
Notifications
You must be signed in to change notification settings - Fork 63
Containerization #336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Containerization #336
Conversation
|
Hello Sibyx It's not production grade, neither documented, but it's works. |
|
Hi @panaC, I noticed the branch (unfortunately, after I created this PR - I already reused some code). I can complete this PR and reuse/document some elements from Please let me know if you're interested in finishing this PR, and if you have any specific requirements, feel free to share them with me. Thanks! |
|
i cannot get it to compile the frontend/manage using npm build |
|
@agelospanagiotakis can you share the error message / docker build output? |
|
@Sibyx no your solution from your repo works as expected. i was confused and i was not testing your solution. |
|
@agelospanagiotakis glad to hear it works. I will try to finish this PR soon |
Hello,
I am trying out the readium-lcp-server with our document server. It is nice to have a prepared Docker image for the server. I have created a simple Dockerfile to run both the lcp and lsd servers.
Some paths I had to use differ from the README (to make it more convenient in terms of mounting our own configuration, etc.).
Right now, both servers run under supervisord in a single container. I would like to also add targets for each server (so configuration without supervisord).
Let me know if you don't mind changes in some paths in README.md and
test/config.yaml- I don't want to introduce redundant files that are just slightly different. Consider this PR as a draft right now. Thanks for the feedback.Interesting files:
compose.yml- contains example configurationDockerfile- Docker image definition.docker/config.yaml- Default config.yaml used for both lcp and lsd. I would like to merge it withtest/config.yamlafter some changes