Skip to content

Conversation

@Sibyx
Copy link

@Sibyx Sibyx commented Aug 8, 2024

Hello,

I am trying out the readium-lcp-server with our document server. It is nice to have a prepared Docker image for the server. I have created a simple Dockerfile to run both the lcp and lsd servers.

Some paths I had to use differ from the README (to make it more convenient in terms of mounting our own configuration, etc.).

Right now, both servers run under supervisord in a single container. I would like to also add targets for each server (so configuration without supervisord).

Let me know if you don't mind changes in some paths in README.md and test/config.yaml - I don't want to introduce redundant files that are just slightly different. Consider this PR as a draft right now. Thanks for the feedback.

Interesting files:

  • compose.yml - contains example configuration
  • Dockerfile - Docker image definition
  • .docker/config.yaml - Default config.yaml used for both lcp and lsd. I would like to merge it with test/config.yaml after some changes

@panaC
Copy link
Member

panaC commented Aug 9, 2024

Hello Sibyx
Have you seen this branch https://github.com/readium/readium-lcp-server/tree/cd_dev/docker ?
this is our containerisation branch at EDRLab to test and deploy LCP server.

It's not production grade, neither documented, but it's works.

@Sibyx
Copy link
Author

Sibyx commented Aug 9, 2024

Hi @panaC,

I noticed the branch (unfortunately, after I created this PR - I already reused some code). I can complete this PR and reuse/document some elements from cd_dev if you're interested. I'm particularly keen on setting up GitHub Actions pipelines and hosting the images on GitHub. My approach to creating the Docker images is slightly different, focusing on read-only, production-ready, Kubernetes-compatible images.

Please let me know if you're interested in finishing this PR, and if you have any specific requirements, feel free to share them with me.

Thanks!

@agelospanagiotakis
Copy link

i cannot get it to compile the frontend/manage using npm build
any ready made solution ?

@Sibyx
Copy link
Author

Sibyx commented Jan 28, 2025

@agelospanagiotakis can you share the error message / docker build output?

@agelospanagiotakis
Copy link

@Sibyx no your solution from your repo works as expected. i was confused and i was not testing your solution.

@Sibyx
Copy link
Author

Sibyx commented Jan 30, 2025

@agelospanagiotakis glad to hear it works. I will try to finish this PR soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants