Add consumer Proguard rules for the LCP module - #814
Draft
mickael-menu wants to merge 1 commit into
Draft
mickael-menu wants to merge 1 commit into
mickael-menu wants to merge 1 commit into
Conversation
LcpClient reaches the liblcp SDK (Lcp, DRMContext, DRMException, DRMError) exclusively through reflection, so R8/Proguard strips or renames org.readium.lcp.sdk classes in minified apps, breaking LicenseValidation. Ship a consumer-rules.pro in readium-lcp - bundled in the AAR and applied automatically to consumer apps - keeping org.readium.lcp.sdk.** so integrators no longer need to declare the rules themselves. Fixes #204 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LcpClientreaches the liblcp SDK (Lcp,DRMContext,DRMException,DRMError) exclusively through reflection, so R8/Proguard strips or renamesorg.readium.lcp.sdkclasses in minified apps, breakingLicenseValidation. Every integrator had to rediscover and declare the keep rules manually.The
readium-lcpmodule now ships aconsumer-rules.profile — bundled in the AAR and applied automatically to consumer apps — keepingorg.readium.lcp.sdk.**.Fixes #204
🤖 Generated with Claude Code