Skip to content

Make target-branch a dropdown option in the pick request template #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cortinico
Copy link
Collaborator

No description provided.

@cortinico cortinico requested a review from cipolleschi February 3, 2025 17:49
Copy link
Collaborator

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is the best approach.
The problem I see is that, every time we create a new release we need to commit a change in the action. Like... in a month before starting 0.79.0-rc.0, we need to remember to bump this, adding the new version and whenever we move a version out of support we have to remove it.

It feels a lot of extra chore for a little gain to me.

@cortinico
Copy link
Collaborator Author

I'm not sure this is the best approach. The problem I see is that, every time we create a new release we need to commit a change in the action. Like... in a month before starting 0.79.0-rc.0, we need to remember to bump this, adding the new version and whenever we move a version out of support we have to remove it.

It feels a lot of extra chore for a little gain to me.

You can actually edit the .md file and merge it directly as this repo has no branch protections (that's the whole idea behind it), so that's literally a one-click option.

This will make sure folks don't use all sorts of versions format + add 2/3 versions in it

@cortinico cortinico marked this pull request as draft March 3, 2025 17:52
@cortinico
Copy link
Collaborator Author

I'll automate this in the future to auto-update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants