Make bundle analysis workflow less fragile #5971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

gaearon merged 2 commits into main from gaearon-patch-49

Apr 28, 2023

Member

gaearon commented Apr 28, 2023

Pin the version (update find-comment string hashicorp/nextjs-bundle-analysis#52 (comment)).
Use the "sticky comment" workflow (feat: update template to use sticky-pull-request-comment hashicorp/nextjs-bundle-analysis#54) to fix the regression introduced by feat: improve monorepo support hashicorp/nextjs-bundle-analysis#44. Alternative to fix: update analyze_comment body-includes #5907.


          Make bundle analysis workflow less fragile

cd8f5aa

facebook-github-bot added CLA Signed React Core Team labels


          Use sticky comment action

4dd6256

vercel bot deployed to Preview

April 28, 2023 15:05

View deployment

gaearon merged commit 609533c into main

Member Author

gaearon commented Apr 28, 2023

This needed an extra fix in 496c578, but works now.

gaearon mentioned this pull request

fix: update analyze_comment body-includes #5907

Closed

rickhanlonii deleted the gaearon-patch-49 branch

April 29, 2024 02:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team