Skip to content

Selected Set announce under process #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Selected Set announce under process #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion js/RNCProgressBarAndroid.android.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import type {ProgressBarAndroidProps} from './types';
* render: function() {
* var progressBar =
* <View style={styles.container}>
* <ProgressBar styleAttr="Inverse" />
* <ProgressBar styleAttr="Inverse" state={} />
* </View>;

* return (
Expand All @@ -49,6 +49,9 @@ ProgressBarAndroidToExport.defaultProps = {
styleAttr: 'Normal',
indeterminate: true,
animating: true,
state: '',
color: 'blue',

};

export default (ProgressBarAndroidToExport: ProgressBarAndroidNativeComponent);
1 change: 1 addition & 0 deletions js/RNCProgressBarAndroidNativeComponent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ type NativeProps = $ReadOnly<{|
animating?: WithDefault<boolean, true>,
color?: ?string,
testID?: ?string,
state?: WithDefault<Object, {}>,
|}>;

export default (requireNativeComponent<NativeProps>(
Expand Down
6 changes: 6 additions & 0 deletions js/__tests__/__snapshots__/RNCProgressBarAndroid.android.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,19 @@
exports[`<ProgressBar /> renders Horizontal ProgressBar 1`] = `
<RNCProgressBar
animating={true}
color="blue"
indeterminate={true}
state=""
styleAttr="Horizontal"
/>
`;

exports[`<ProgressBar /> renders Inverse ProgressBar 1`] = `
<RNCProgressBar
animating={true}
color="blue"
indeterminate={true}
state=""
styleAttr="Normal"
typeAttr="Inverse"
/>
Expand All @@ -20,7 +24,9 @@ exports[`<ProgressBar /> renders Inverse ProgressBar 1`] = `
exports[`<ProgressBar /> renders enabled ProgressBar 1`] = `
<RNCProgressBar
animating={true}
color="blue"
indeterminate={true}
state=""
styleAttr="Normal"
/>
`;
8 changes: 7 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"homepage": "https://github.com/react-native-community/react-native-progress-bar-android#readme",
"repository": {
"type": "git",
"url": "https://github.com/react-native-community/react-native-progress-bar-android.git"
"url": "git+https://github.com/react-native-community/react-native-progress-bar-android.git"
},
"keywords": [
"react-native",
Expand Down Expand Up @@ -61,5 +61,11 @@
},
"publishConfig": {
"access": "public"
},
"bugs": {
"url": "https://github.com/react-native-community/react-native-progress-bar-android/issues"
},
"directories": {
"example": "example"
}
}
Loading