Fix division by zero minute interval #997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nterval is 0 - Add safety check in adjustMinimumDate function to handle minuteInterval <= 0 - Return minimumDate unchanged when no valid interval is provided - Add debug logging to track minuteInterval values for troubleshooting - Fixes EXC_ARITHMETIC (EXC_I386_DIV) crash when modulo operation encounters zero divisor This fixes crashes that occur when DateTimePicker is used without explicitly setting minuteInterval, as the default value becomes 0 instead of the expected 1, causing division by zero in the modulo operation.
Only log when minuteInterval <= 0 and we return date unchanged. Remove verbose logging for normal operation to reduce console noise.
vonovak
reviewed
Aug 8, 2025
vonovak
merged commit e65a5d3
into
react-native-datetimepicker:master
1 of 3 checks passed
vonovak
pushed a commit
that referenced
this pull request
Aug 8, 2025
## [8.4.4](v8.4.3...v8.4.4) (2025-08-08) ### Bug Fixes * **ios:** remove potential division by zero minute interval ([#997](#997)) ([e65a5d3](e65a5d3))
|
🎉 This issue has been resolved in version 8.4.4 🎉 If this package helps you, consider sponsoring us! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The application crashes when
minuteIntervalis not provided or is 0. The issue was introduced in the previous PR which modified the minimum date check #992Fixes #996
Test Plan
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.mdexample/App.js)