lore: lore/implementation-loop/issue-1648 - #1693

Draft

lore-agent[bot] wants to merge 1 commit into

mainfrom

lore/implementation-loop/issue-1648

lore-agent Bot commented Aug 31, 2026

Contributor

Opened by the Lore assembly line from lore/implementation-loop/issue-1648.

Closes #1648
Lore-Task: f140a166-0d75-485b-8bf8-cf5464e50b78


          test(implementation-loop): acceptance tests for claim gate with pause…

1f64f64

…d central (#1648)

Add two acceptance tests that exercise the harness's `claimAs` / `pause`
seam for the first time — proving the full registry → claim → walk path on
the real blueprint. Before this, all implementation-loop acceptance tests used
`completeAgentNode` directly, bypassing `mayClaim`. The tests show:

- satellite claims every node through the real gate when central is paused
  (no validate node means node:agent is all it needs, FR2 fix)
- paused central returns null from the claim gate, not an error

Link both tests to the spec statement at running-stations-in-any-k8s-cluster
spec.md lines 314-319 ("acceptance tier spans registry → claim → walk →
reaper on the real implementation-loop blueprint").

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

lore-agent Bot added the agent-generated label

github-actions Bot commented Aug 31, 2026

🔍 Lore Spec Impact — advisory

This PR touches 11 statement(s) across 3 spec(s), and 1 of them has validating tests this PR does not change.

Feature Specification: Running Stations in Any Kubernetes Cluster · 1 statement(s)

specs/running-stations-in-any-k8s-cluster/spec.md

FR3 — Claim-based dispatch
⚠ the tests that validate it are not touched by this PR

only its test links changed — the statement text itself is unchanged

The acceptance tier therefore spans registry → claim → walk → reaper on the real implementation-loop blueprint: a pau…

validated by apps/floor/src/jobs/assembly-run/assembly-run-reaper.test.ts:1134, apps/floor/src/jobs/station/single-cr-dispatch-acceptance.test.ts:184

Weaker signals (10) — linked by a spec, not proven by a test run

Feature Specification: Dark Factory Mode · 1 statement(s)

specs/6-dark-factory/spec.md

FR6 — Assembly line identity
✓ this PR also changes the tests that validate it

FR6.60 (added 2026-08-28) A CR that fails because an AgentDefinition's skills_source is unreachable MUST raise …

validated by apps/floor/src/jobs/assembly-run/implementation-loop-acceptance.test.ts:80
via changed file apps/floor/src/jobs/assembly-run/implementation-loop-acceptance.test.ts

Feature Specification: Implementation Loop · 9 statement(s)

specs/implementation-loop/spec.md

FR2 — The loop is a driver, not a cyclic assembly line
✓ this PR also changes the tests that validate it

The driver runs on a cron tick as a safety net and is also re-armed from the run's terminal hook — finishLine's winni…

validated by apps/floor/src/jobs/assembly-run/implementation-loop-acceptance.test.ts:80
via changed file apps/floor/src/jobs/assembly-run/implementation-loop-acceptance.test.ts

FR3 — The assembly line definition
✓ this PR also changes the tests that validate it

The implementation-loop definition is top-down: acceptance tests bound the work before any of it is done, one red-gre…

validated by apps/floor/src/jobs/assembly-run/implementation-loop-acceptance.test.ts:80
via changed file apps/floor/src/jobs/assembly-run/implementation-loop-acceptance.test.ts

FR3 — The assembly line definition
✓ this PR also changes the tests that validate it

tdd-round loops on changes_requested — "round green, work remains" — with iteration_max: 12, and leaves on `succe…

validated by apps/floor/src/jobs/assembly-run/implementation-loop-acceptance.test.ts:80
via changed file apps/floor/src/jobs/assembly-run/implementation-loop-acceptance.test.ts

FR3 — The assembly line definition
✓ this PR also changes the tests that validate it

Red CI routes await-pr to fix-ci and back to the wait, rather than blocking the ticket. The cycle touches a human s…

validated by apps/floor/src/jobs/assembly-run/implementation-loop-acceptance.test.ts:80
via changed file apps/floor/src/jobs/assembly-run/implementation-loop-acceptance.test.ts

FR3 — The assembly line definition
✓ this PR also changes the tests that validate it

dod retries itself once on failed, and routes changes_requested — "this ticket cannot be expressed as acceptance …

validated by apps/floor/src/jobs/assembly-run/implementation-loop-acceptance.test.ts:80
via changed file apps/floor/src/jobs/assembly-run/implementation-loop-acceptance.test.ts

FR3 — The assembly line definition
✓ this PR also changes the tests that validate it

A revisit is numbered past the node's HIGHEST recorded iteration, not per edge: (node, iteration) is the row identity…

validated by apps/floor/src/jobs/assembly-run/implementation-loop-acceptance.test.ts:80
via changed file apps/floor/src/jobs/assembly-run/implementation-loop-acceptance.test.ts

FR4 — Waiting on the pull request
✓ this PR also changes the tests that validate it

A node of type pr_review parks: apps/floor/src/jobs/assembly-run/advance.ts mints the station run row but dispatche…

validated by apps/floor/src/jobs/assembly-run/implementation-loop-acceptance.test.ts:80
via changed file apps/floor/src/jobs/assembly-run/implementation-loop-acceptance.test.ts

FR4 — Waiting on the pull request
✓ this PR also changes the tests that validate it

The two blocking reasons resume with DIFFERENT outcomes, because only outcome routes — selectEdge matches on it alo…

validated by apps/floor/src/jobs/assembly-run/implementation-loop-acceptance.test.ts:80
via changed file apps/floor/src/jobs/assembly-run/implementation-loop-acceptance.test.ts

FR8 — Blocked tickets never stall the loop
✓ this PR also changes the tests that validate it

When a run ends blocked or errored, the driver applies lore:blocked to the issue and comments on it explaining why, n…

validated by apps/floor/src/jobs/assembly-run/implementation-loop-acceptance.test.ts:80
via changed file apps/floor/src/jobs/assembly-run/implementation-loop-acceptance.test.ts

1 new statement(s) have no test link yet.

_{Deterministic · graph @ b079b26 (projected 2026-08-31) · no tests run by this check}

lore-agent Bot mentioned this pull request

central cluster-agent is paused and is the only provider of 7 of 8 node tags #1648

Open

lore-agent Bot commented Aug 31, 2026

Contributor Author

Lore implementation-loop run failed (failed — node "tdd-round" failed: BackoffLimitExceeded: Job has reached the specified backoff limit — The pod died rather than the work failing — a crash, an OOM, an eviction, or a Job deadline. Re-running is the right response; check pod events if it repeats.) — d34bf9fb-cc94-41fe-96b2-b19764363ab9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-generated