Skip to content

lore: lore/implementation-loop/issue-1647 - #1689

Draft
lore-agent[bot] wants to merge 1 commit into
mainfrom
lore/implementation-loop/issue-1647
Draft

lore: lore/implementation-loop/issue-1647#1689
lore-agent[bot] wants to merge 1 commit into
mainfrom
lore/implementation-loop/issue-1647

Conversation

@lore-agent

@lore-agent lore-agent Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Opened by the Lore assembly line from lore/implementation-loop/issue-1647.

Closes #1647
Lore-Task: cb1e5fa8-1de9-4ae7-83fc-7d036eb27dc8

… loop

Adds a red acceptance test asserting that pruneOnce deletes the per-task
GH_TOKEN_* key from agent-secrets when it sweeps an orphaned pt-* definition.
On a satellite cluster the Floor's DELETE /api/cluster/per-task-tokens/{taskId}
call targets only the central cluster-agent, so the prune loop is the sole
reclaim path — currently it does not call any secret key deletion and the key
accumulates indefinitely.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

🔍 Lore Spec Impact — advisory

This PR touches 2 statement(s) across 1 spec(s), and changes the validating tests alongside every one of them.

Feature Specification: Running Stations in Any Kubernetes Cluster · 2 statement(s)

specs/running-stations-in-any-k8s-cluster/spec.md

FR4 — Liveness, recovery, and dead-agent reaping
✓ this PR also changes the tests that validate it

A cluster forgets what it finished with (added 2026-08-30). Every run leaves an Agent CR plus the per-task pt-*

validated by apps/cluster-agent/src/reap/prune-loop.test.ts:109, apps/cluster-agent/src/reap/decide-prune.test.ts:137

FR4 — Liveness, recovery, and dead-agent reaping
✓ this PR also changes the tests that validate it

The sweep never throws: a cluster it cannot reach, or one object wedged by a finalizer, is an outcome it logs and carri…

validated by apps/cluster-agent/src/reap/prune-loop.test.ts:109

3 new statement(s) have no test link yet.

Deterministic · graph @ b079b26 (projected 2026-08-31) · no tests run by this check

@lore-agent

lore-agent Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

Lore implementation-loop run failed (failed — node "tdd-round" failed) — 87a7e5f8-022e-4bed-bfd2-85e5f1716a00.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Satellite-provisioned per-run tokens are never reclaimed (agent-secrets leak)

0 participants