Rdkb 62887#22
Closed
jayasrikadiyal wants to merge 4 commits intodevelopfrom
Closed
Conversation
Reason for change: To fix the issue. Test Procedure: Tested on RG Risks: Low Priority:P2 Signed-off-by:jayasrikadiyala@gmail.com
Reason for change: To fix the issue. Test Procedure: Tested on RG Risks: Low Priority:P2 Signed-off-by:jayasrikadiyala@gmail.com
Reason for change: To fix the issue. Test Procedure: Tested on RG Risks: Low Priority:P2 Signed-off-by:jayasrikadiyala@gmail.com
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Pull request overview
This PR aims to reduce verbosity in the SNMP module (RDKB-62887) by downgrading several SNMP log statements from Info/Warning to Debug and introducing a local debug header.
Changes:
- Added
ccsp_snmp_debug.hand included it in several SNMP source files. - Changed multiple
AnscTraceInfo/AnscTraceWarninglog statements toAnscTraceDebug. - Changed
Cosa_GetParamValues()“GET called/success” logs fromCcspTraceInfotoCcspTraceDebug.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| source/include/ccsp_snmp_debug.h | Introduces an AnscTraceDebug macro override used by SNMP sources. |
| source/custom/ccsp_snmp_common.c | Includes new debug header and downgrades “dest comp not found” logs to Debug. |
| source/SnmpPlugin/cosa_api.c | Downgrades SNMP GET call/success logs from Info to Debug. |
| source/SnmpPlugin/ccsp_table_helper_control.c | Includes new debug header; downgrades a cache-handler registration log to Debug. |
| source/SnmpPlugin/ccsp_table_helper_access.c | Includes new debug header; downgrades “dest comp not found” log to Debug. |
| source/SnmpPlugin/ccsp_scalar_helper_control.c | Includes new debug header; downgrades a cache-handler registration log to Debug. |
| source/SnmpPlugin/ccsp_scalar_helper_access.c | Includes new debug header; downgrades “dest comp not found” log to Debug. |
| source/SnmpPlugin/ccsp_mib_utilities.c | Includes new debug header; downgrades “dest comp not found” log to Debug. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } while (0) | ||
| #else | ||
| #define CCSP_SNMP_DEBUG_TRACE(a) \ | ||
| do { \ |
Comment on lines
+24
to
+30
|
|
||
| #ifndef CCSP_SNMP_DEBUG_TRACE | ||
| #if defined(CCSP_SNMP_ENABLE_DEBUG_PRINT) | ||
| #define CCSP_SNMP_DEBUG_TRACE(a) \ | ||
| do { \ | ||
| printf("%s:%d> ", __FUNCTION__, __LINE__); \ | ||
| printf a; \ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To reduce logging in SNMP module.
https://ccp.sys.comcast.net/browse/RDKB-62887