Feature/rdk 60236 comma

[Abhinavpv28]

No description provided.

[Copilot]

Pull request overview

This PR adds support for issue-type “suffixes” (the substring starting at the first underscore) so that the base issue type is used for profile lookup/processing while the suffix can be preserved and appended when uploading debug output artifacts.

Changes:

• Add data_buf::suffix and propagate initialization/cleanup in the message-buffer lifecycle.
• Introduce split_issue_type() and update issue-type processing to split base vs suffix per comma-separated issue token.
• Update issue-type sanitization to retain _ and -, and adjust/add unit tests around the new behavior.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
src/unittest/rrdUnitTestRunner.cpp	Updates unit tests for issue-type splitting/suffix behavior and message-buffer setup.
src/unittest/UTJson/device.properties	Unit test data file used during GTest runs.
src/rrdJsonParser.h	Exposes new split_issue_type() helper.
src/rrdJsonParser.c	Implements split_issue_type() and uses buff->suffix when constructing upload artifact names; adds additional cleanup.
src/rrdInterface.c	Initializes and frees the new data_buf::suffix field.
src/rrdEventProcess.c	Splits each issue token into base+suffix and stores suffix per token; expands allowed characters to keep _/-.
src/rrdCommon.h	Extends data_buf with a suffix pointer.

[github-actions]

Code Coverage Summary

                               Total:|83.1%   5949|97.0%  1532|    -      0

[Copilot]

Pull request overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (3)

src/unittest/rrdUnitTestRunner.cpp:1918

• These new tests expect issueTypeSplitter to extract an underscore suffix into outsuffix, but the production issueTypeSplitter only splits on the provided delimiter and has no suffix output. Consider testing split_issue_type() directly for suffix extraction, and keep issueTypeSplitter tests focused on delimiter-splitting behavior.

/* --------------- Test processIssueTypeInDynamicProfile() from rrdEventProcess --------------- */
class ProcessIssueTypeInDynamicProfileTest : public ::testing::Test
{
protected:
    issueNodeData issuestructNode;
    data_buf buff;

src/unittest/rrdUnitTestRunner.cpp:1871

• issueTypeSplitter is a static int issueTypeSplitter(char*, const char, char***) in rrdEventProcess.c (3 params). These test calls pass 4 arguments, so this won’t compile when including rrdEventProcess.c into the runner. Update the tests to match the actual signature (or change the function signature consistently if that’s intended).

    char **args = NULL;
    int count = issueTypeSplitter(str, ',', &args);

src/unittest/rrdUnitTestRunner.cpp:1909

• issueTypeSplitter allocates args[i] strings (see implementation in rrdEventProcess.c), but this test only frees args and leaks args[0]. Free each args[i] (including index 0) before freeing the array, as done in the other splitter tests.

    int count = issueTypeSplitter(str, ',', &args);

    ASSERT_EQ(count, 1);

    free(args);