544,542,541-Changes required for the YTs testcase to pass#196
Conversation
There was a problem hiding this comment.
Pull request overview
Updates resident app behavior to address YouTube test case expectations by adjusting power-state transition handling and enriching YouTube launch URLs with additional query parameters.
Changes:
- Added a special-case handler for
DEEP_SLEEP -> LIGHT_SLEEPonSystemPowerStateChangednotifications inApp.js. - Appended
utm_contentquery parameter to YouTube/YouTubeTV launch URLs formenuandguidelaunch reasons inAppApi.js.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| accelerator-home-ui/src/App.js | Adds additional power-state transition handling logic inside the system power-state listener. |
| accelerator-home-ui/src/api/AppApi.js | Adds utm_content injection into YouTube launch URLs for specific launch locations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (3)
accelerator-home-ui/src/App.js:1025
- In the
onLaunchedhandler (suspend branch), the newremoveKeyInterceptfor keyCode 115 usesclient: data.callsign, but this event usesdata.client(as used by the other intercept removals in the same block). This likely leaves the 115 intercept installed.
RDKShellApis.removeKeyIntercept({
"keyCode": 115,
"modifiers": [],
"client": data.callsign
}).then(res => {
accelerator-home-ui/src/App.js:1049
- In the
onSuspendedhandler, the newremoveKeyInterceptfor keyCode 115 usesclient: data.callsigneven though this handler usesdata.clienteverywhere else. This mismatch likely prevents the 115 intercept from being removed for YouTube.
RDKShellApis.removeKeyIntercept({
"keyCode": 115,
"modifiers": [],
"client": data.callsign
}).then(res => {
accelerator-home-ui/src/App.js:1074
- In the
onPluginSuspendedhandler, the newremoveKeyInterceptfor keyCode 115 usesclient: data.callsignbut this event handler is keyed offdata.client. This likely causes the remove call to target the wrong/undefined client.
RDKShellApis.removeKeyIntercept({
"keyCode": 115,
"modifiers": [],
"client": data.callsign
}).then(res => {
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (4)
accelerator-home-ui/src/App.js:980
- This
removeKeyInterceptblock uses tab-indentation and a different formatting style than the other intercept removals directly above. Please reformat to match the surrounding style (or extract a shared helper) to avoid inconsistent formatting across handlers.
RDKShellApis.removeKeyIntercept({
"keyCode": 115,
"modifiers": [],
"client": data.client
}).then(res => {
accelerator-home-ui/src/App.js:1025
- This
removeKeyInterceptaddition is formatted differently (tabs / multi-line object) than the other key intercept removals in this handler. Consider reformatting to match the established one-line style for consistency.
RDKShellApis.removeKeyIntercept({
"keyCode": 115,
"modifiers": [],
"client": data.client
}).then(res => {
accelerator-home-ui/src/App.js:1049
- This new
removeKeyInterceptcall is using a different indentation/formatting style than the surrounding code (tabs + multi-line object). Please align formatting with nearby intercept calls to keep the file consistent.
RDKShellApis.removeKeyIntercept({
"keyCode": 115,
"modifiers": [],
"client": data.client
}).then(res => {
accelerator-home-ui/src/App.js:1074
- This
removeKeyInterceptblock introduces tab-indentation and a different formatting pattern than the other intercept removals in this section. Please reformat consistently with the surrounding calls.
RDKShellApis.removeKeyIntercept({
"keyCode": 115,
"modifiers": [],
"client": data.client
}).then(res => {
No description provided.