Skip to content

544,542,541-Changes required for the YTs testcase to pass#196

Merged
suryag23 merged 4 commits into
support/rdk7-mainfrom
544
May 21, 2026
Merged

544,542,541-Changes required for the YTs testcase to pass#196
suryag23 merged 4 commits into
support/rdk7-mainfrom
544

Conversation

@suryag23
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates resident app behavior to address YouTube test case expectations by adjusting power-state transition handling and enriching YouTube launch URLs with additional query parameters.

Changes:

  • Added a special-case handler for DEEP_SLEEP -> LIGHT_SLEEP onSystemPowerStateChanged notifications in App.js.
  • Appended utm_content query parameter to YouTube/YouTubeTV launch URLs for menu and guide launch reasons in AppApi.js.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
accelerator-home-ui/src/App.js Adds additional power-state transition handling logic inside the system power-state listener.
accelerator-home-ui/src/api/AppApi.js Adds utm_content injection into YouTube launch URLs for specific launch locations.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread accelerator-home-ui/src/App.js Outdated
Comment thread accelerator-home-ui/src/App.js Outdated
Comment thread accelerator-home-ui/src/api/AppApi.js Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (3)

accelerator-home-ui/src/App.js:1025

  • In the onLaunched handler (suspend branch), the new removeKeyIntercept for keyCode 115 uses client: data.callsign, but this event uses data.client (as used by the other intercept removals in the same block). This likely leaves the 115 intercept installed.
          RDKShellApis.removeKeyIntercept({
					"keyCode": 115,
					"modifiers": [],
					"client": data.callsign
				}).then(res => {

accelerator-home-ui/src/App.js:1049

  • In the onSuspended handler, the new removeKeyIntercept for keyCode 115 uses client: data.callsign even though this handler uses data.client everywhere else. This mismatch likely prevents the 115 intercept from being removed for YouTube.
        RDKShellApis.removeKeyIntercept({
					"keyCode": 115,
					"modifiers": [],
					"client": data.callsign
				}).then(res => {

accelerator-home-ui/src/App.js:1074

  • In the onPluginSuspended handler, the new removeKeyIntercept for keyCode 115 uses client: data.callsign but this event handler is keyed off data.client. This likely causes the remove call to target the wrong/undefined client.
        RDKShellApis.removeKeyIntercept({
					"keyCode": 115,
					"modifiers": [],
					"client": data.callsign
				}).then(res => {

Comment thread accelerator-home-ui/src/App.js Outdated
Comment thread accelerator-home-ui/src/App.js Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (4)

accelerator-home-ui/src/App.js:980

  • This removeKeyIntercept block uses tab-indentation and a different formatting style than the other intercept removals directly above. Please reformat to match the surrounding style (or extract a shared helper) to avoid inconsistent formatting across handlers.
        RDKShellApis.removeKeyIntercept({
					"keyCode": 115,
					"modifiers": [],
					"client": data.client
				}).then(res => {

accelerator-home-ui/src/App.js:1025

  • This removeKeyIntercept addition is formatted differently (tabs / multi-line object) than the other key intercept removals in this handler. Consider reformatting to match the established one-line style for consistency.
          RDKShellApis.removeKeyIntercept({
					"keyCode": 115,
					"modifiers": [],
					"client": data.client
				}).then(res => {

accelerator-home-ui/src/App.js:1049

  • This new removeKeyIntercept call is using a different indentation/formatting style than the surrounding code (tabs + multi-line object). Please align formatting with nearby intercept calls to keep the file consistent.
        RDKShellApis.removeKeyIntercept({
					"keyCode": 115,
					"modifiers": [],
					"client": data.client
				}).then(res => {

accelerator-home-ui/src/App.js:1074

  • This removeKeyIntercept block introduces tab-indentation and a different formatting pattern than the other intercept removals in this section. Please reformat consistently with the surrounding calls.
        RDKShellApis.removeKeyIntercept({
					"keyCode": 115,
					"modifiers": [],
					"client": data.client
				}).then(res => {

Comment thread accelerator-home-ui/src/App.js
Comment thread accelerator-home-ui/src/App.js
@suryag23 suryag23 merged commit 8c968d0 into support/rdk7-main May 21, 2026
7 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants