Feature/final m wand oss mw testing#737
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the RDK distro configuration to add middleware-related stack layer extensions and to register additional OPKG/IPK feed URIs for middleware debug packages.
Changes:
- Adds
STACK_LAYER_EXTENSIONentries derived from${MIDDLEWARE_ARCH}and a computed${MW_OSS}suffix. - Registers two new
IPK_FEED_URISentries pointing to Artifactory-hosted middleware debug IPK feeds.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| MW_IPK_SERVER_PATH = "https://partners.artifactory.comcast.com/artifactory/middleware-dbg/mw-ipk-mode/${MACHINE}/ipks/debug" | ||
| IPK_FEED_URIS += " ${MIDDLEWARE_ARCH}##${MW_IPK_SERVER_PATH}" | ||
|
|
||
| # Make sure get_oss_arch(d) is defined before this is used |
There was a problem hiding this comment.
${@get_oss_arch(d)} is referenced here, but get_oss_arch is not defined anywhere in this repository (searching for get_oss_arch/def get_oss_arch only finds this usage). This will cause a BitBake parse/evaluation error when expanding MW_OSS. Define get_oss_arch in a conf/include/class that is always in scope for this distro, or replace this with an existing BitBake/oe-core mechanism (or provide a safe fallback if the function is unavailable).
| # Make sure get_oss_arch(d) is defined before this is used | |
| def get_oss_arch(d): | |
| return d.getVar('OSS_ARCH') or d.getVar('MIDDLEWARE_ARCH') or d.getVar('TARGET_ARCH') or '' |
| STACK_LAYER_EXTENSION = "${MIDDLEWARE_ARCH}" | ||
|
|
||
| MW_IPK_SERVER_PATH = "https://partners.artifactory.comcast.com/artifactory/middleware-dbg/mw-ipk-mode/${MACHINE}/ipks/debug" | ||
| IPK_FEED_URIS += " ${MIDDLEWARE_ARCH}##${MW_IPK_SERVER_PATH}" |
There was a problem hiding this comment.
MIDDLEWARE_ARCH is used to form STACK_LAYER_EXTENSION and as the feed name in IPK_FEED_URIS, but within this repository it's only assigned in conf/distro/include/rdkb.inc and that include does not appear to be required/included by conf/distro/rdk.conf (or any other conf/inc here). If MIDDLEWARE_ARCH isn't set by the calling environment, this expands to an empty feed key (##<url>). Consider setting a default (?=) in a file that is always included for this distro, or explicitly require the include that defines it.
| MW_IPK_SERVER_PATH = "https://partners.artifactory.comcast.com/artifactory/middleware-dbg/mw-ipk-mode/${MACHINE}/ipks/debug" | ||
| IPK_FEED_URIS += " ${MIDDLEWARE_ARCH}##${MW_IPK_SERVER_PATH}" |
There was a problem hiding this comment.
MW_IPK_SERVER_PATH is assigned with = to a hard-coded external URL. If builds need to point at different Artifactory repos (mirrors/offline/non-debug), this is hard to override. Consider using ?= (or deriving it from a single base URL variable) so downstream/local configs can override without patching the distro config.
| MW_OSS = "${@get_oss_arch(d)}${MW_EXTENSION}" | ||
| STACK_LAYER_EXTENSION += " ${MW_OSS}" | ||
|
|
||
| MW_OSS_IPK_SERVER_PATH = "https://partners.artifactory.comcast.com/artifactory/middleware-dbg/mw-ipk-mode/${MACHINE}/${MW_OSS}/ipks/debug" |
There was a problem hiding this comment.
MW_OSS_IPK_SERVER_PATH is assigned with = to a hard-coded external URL. Consider using ?= (or deriving from a shared base URL variable) so downstream/local configs can redirect the feed location without patching this distro config.
| MW_OSS_IPK_SERVER_PATH = "https://partners.artifactory.comcast.com/artifactory/middleware-dbg/mw-ipk-mode/${MACHINE}/${MW_OSS}/ipks/debug" | |
| MW_OSS_IPK_SERVER_PATH ?= "https://partners.artifactory.comcast.com/artifactory/middleware-dbg/mw-ipk-mode/${MACHINE}/${MW_OSS}/ipks/debug" |
No description provided.