Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions recipes-extended/aamp/aamp_git.bb
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@ SECTION = "console/utils"
LICENSE = "Apache-2.0"
LIC_FILES_CHKSUM = "file://LICENSE;md5=97dd37dbf35103376811825b038fc32b"

PV ?= "3.3.0"
PR ?= "r0"
PV ?= "3.3.0.e"
PR ?= "r"
Copy link

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is set to "r", which deviates from the layer’s convention of numeric package revisions (r0, r1, ...). For example: recipes-extended/devicesettings/devicesettings_git.bb:8 has PR = "r0" and recipes-multimedia/media-utils/media-utils_git.bb:9 has PR ?= "r0". Keeping PR numeric also avoids odd ${PV}-${PR} strings and version/upgrade ordering issues. Consider using r0 (if PV is bumped) or incrementing to r1 (if this is purely a recipe-only revision bump).

Suggested change
PR ?= "r"
PR ?= "r0"

Copilot uses AI. Check for mistakes.

SRCREV_FORMAT = "aamp"
SRCREV_aamp ?= "32ffcb2f9ba33838d243954abca53a9195cc2762"
SRCREV_aamp ?= "1bb7dc4d1f09340b75bd9b83a2864d0b51f44019"

DEPENDS += "curl libdash libxml2 cjson readline ${@bb.utils.contains('DISTRO_FEATURES', 'build_external_player_interface', 'player-interface', '', d)} ${@bb.utils.contains('DISTRO_FEATURES', 'webkitbrowser-plugin', '${WPEWEBKIT}', '', d)} ${@bb.utils.contains('DISTRO_FEATURES', 'subtec', 'closedcaption-hal-headers virtual/vendor-dvb virtual/vendor-closedcaption-hal', '', d)} ${@bb.utils.contains('DISTRO_FEATURES', 'enable_rialto', 'dobby', '', d)}"

Expand Down
Loading