RDKEMW-14497: Create L0 tests with Copilot for DownloadManager#371
Open
mounikapalem wants to merge 18 commits intodevelopfrom
Open
RDKEMW-14497: Create L0 tests with Copilot for DownloadManager#371mounikapalem wants to merge 18 commits intodevelopfrom
mounikapalem wants to merge 18 commits intodevelopfrom
Conversation
Reason for change: Implemented L0 tests for DownloadManager
ad65bd3 to
d5bb407
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new L0 test target for the DownloadManager plugin and wires it into the existing L0 test build/run pipeline.
Changes:
- Introduces DownloadManager L0 test sources (shell/lifecycle, implementation, HTTP client, telemetry) plus supporting mocks.
- Adds a new
downloadmanager_l0testtarget toTests/L0Tests/CMakeLists.txtwith coverage/warnings options and required link deps. - Updates the L0 GitHub Actions workflow to build the DownloadManager plugin and run the new L0 test executable.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| Tests/L0Tests/DownloadManager/ServiceMock.h | Adds DownloadManager-focused IShell/ISubSystem fakes plus IDownloadManager/notification test fakes. |
| Tests/L0Tests/DownloadManager/DownloadManager_TelemetryTests.cpp | Adds singleton/init/reset “no-crash” coverage for telemetry reporting. |
| Tests/L0Tests/DownloadManager/DownloadManager_LifecycleTests.cpp | Adds shell-plugin lifecycle tests using the new ServiceMock and fake implementation. |
| Tests/L0Tests/DownloadManager/DownloadManager_ImplementationTests.cpp | Adds broad L0 coverage for DownloadManagerImplementation behavior including queueing, thread paths, and error paths. |
| Tests/L0Tests/DownloadManager/DownloadManager_HttpClientTests.cpp | Adds L0 coverage for DownloadManagerHttpClient including callbacks and file IO helpers. |
| Tests/L0Tests/DownloadManager/DownloadManagerTest.cpp | Adds a test runner binary aggregating all DownloadManager L0 tests. |
| Tests/L0Tests/CMakeLists.txt | Adds DownloadManager L0 target, options, include/link setup, and coverage integration. |
| .github/workflows/L0-tests.yml | Enables building DownloadManager in CI and runs downloadmanager_l0test with log capture. |
added 2 commits
April 28, 2026 14:37
added 2 commits
April 28, 2026 16:33
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented L0 tests for DownloadManager