Skip to content

RDKEMW-14497: Create L0 tests with Copilot for DownloadManager#371

Open
mounikapalem wants to merge 18 commits intodevelopfrom
topic/RDKEMW-14497
Open

RDKEMW-14497: Create L0 tests with Copilot for DownloadManager#371
mounikapalem wants to merge 18 commits intodevelopfrom
topic/RDKEMW-14497

Conversation

@mounikapalem
Copy link
Copy Markdown
Contributor

Implemented L0 tests for DownloadManager

@mounikapalem mounikapalem requested review from a team as code owners April 28, 2026 07:44
    Reason for change: Implemented L0 tests for DownloadManager
Copilot AI review requested due to automatic review settings April 28, 2026 10:21
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new L0 test target for the DownloadManager plugin and wires it into the existing L0 test build/run pipeline.

Changes:

  • Introduces DownloadManager L0 test sources (shell/lifecycle, implementation, HTTP client, telemetry) plus supporting mocks.
  • Adds a new downloadmanager_l0test target to Tests/L0Tests/CMakeLists.txt with coverage/warnings options and required link deps.
  • Updates the L0 GitHub Actions workflow to build the DownloadManager plugin and run the new L0 test executable.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 10 comments.

Show a summary per file
File Description
Tests/L0Tests/DownloadManager/ServiceMock.h Adds DownloadManager-focused IShell/ISubSystem fakes plus IDownloadManager/notification test fakes.
Tests/L0Tests/DownloadManager/DownloadManager_TelemetryTests.cpp Adds singleton/init/reset “no-crash” coverage for telemetry reporting.
Tests/L0Tests/DownloadManager/DownloadManager_LifecycleTests.cpp Adds shell-plugin lifecycle tests using the new ServiceMock and fake implementation.
Tests/L0Tests/DownloadManager/DownloadManager_ImplementationTests.cpp Adds broad L0 coverage for DownloadManagerImplementation behavior including queueing, thread paths, and error paths.
Tests/L0Tests/DownloadManager/DownloadManager_HttpClientTests.cpp Adds L0 coverage for DownloadManagerHttpClient including callbacks and file IO helpers.
Tests/L0Tests/DownloadManager/DownloadManagerTest.cpp Adds a test runner binary aggregating all DownloadManager L0 tests.
Tests/L0Tests/CMakeLists.txt Adds DownloadManager L0 target, options, include/link setup, and coverage integration.
.github/workflows/L0-tests.yml Enables building DownloadManager in CI and runs downloadmanager_l0test with log capture.

Comment thread Tests/L0Tests/DownloadManager/DownloadManager_LifecycleTests.cpp Outdated
Comment thread Tests/L0Tests/DownloadManager/DownloadManager_LifecycleTests.cpp Outdated
Comment thread Tests/L0Tests/DownloadManager/DownloadManager_HttpClientTests.cpp Outdated
Comment thread Tests/L0Tests/DownloadManager/DownloadManager_HttpClientTests.cpp Outdated
Comment thread Tests/L0Tests/DownloadManager/DownloadManager_LifecycleTests.cpp
Comment thread Tests/L0Tests/DownloadManager/DownloadManager_LifecycleTests.cpp
Comment thread .github/workflows/L0-tests.yml
Comment thread Tests/L0Tests/DownloadManager/DownloadManager_HttpClientTests.cpp Outdated
Comment thread Tests/L0Tests/DownloadManager/DownloadManager_HttpClientTests.cpp Outdated
Comment thread Tests/L0Tests/DownloadManager/DownloadManager_ImplementationTests.cpp Outdated
Copilot AI review requested due to automatic review settings April 28, 2026 11:45
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.

Comment thread Tests/L0Tests/DownloadManager/ServiceMock.h
Comment thread Tests/L0Tests/DownloadManager/DownloadManager_LifecycleTests.cpp
Comment thread Tests/L0Tests/DownloadManager/DownloadManager_LifecycleTests.cpp
Comment thread .github/workflows/L0-tests.yml
Copilot AI review requested due to automatic review settings April 28, 2026 14:17
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.

Comment thread Tests/L0Tests/DownloadManager/ServiceMock.h Outdated
Comment thread Tests/L0Tests/DownloadManager/DownloadManager_HttpClientTests.cpp Outdated
Comment thread Tests/L0Tests/DownloadManager/DownloadManager_LifecycleTests.cpp
Copilot AI review requested due to automatic review settings April 28, 2026 15:03
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 9 comments.

Comment thread Tests/L0Tests/DownloadManager/DownloadManagerTest.cpp
Comment thread Tests/L0Tests/DownloadManager/ServiceMock.h
Comment thread Tests/L0Tests/DownloadManager/DownloadManager_ImplementationTests.cpp Outdated
Comment thread Tests/L0Tests/DownloadManager/ServiceMock.h Outdated
Comment thread Tests/L0Tests/DownloadManager/DownloadManager_HttpClientTests.cpp Outdated
Comment thread Tests/L0Tests/DownloadManager/DownloadManager_LifecycleTests.cpp Outdated
Comment thread Tests/L0Tests/DownloadManager/DownloadManager_LifecycleTests.cpp Outdated
Comment thread Tests/L0Tests/CMakeLists.txt
Copilot AI review requested due to automatic review settings April 29, 2026 05:55
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Comment thread Tests/L0Tests/DownloadManager/DownloadManager_LifecycleTests.cpp Outdated
Comment thread Tests/L0Tests/DownloadManager/DownloadManager_LifecycleTests.cpp
mnaras301_comcast and others added 2 commits April 29, 2026 06:20
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 29, 2026 06:48
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Comment thread Tests/L0Tests/DownloadManager/ServiceMock.h
Comment thread Tests/L0Tests/DownloadManager/DownloadManager_LifecycleTests.cpp
Comment thread Tests/L0Tests/DownloadManager/DownloadManager_LifecycleTests.cpp Outdated
Copilot AI review requested due to automatic review settings April 29, 2026 15:09
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.

Comment thread .github/workflows/L0-tests.yml Outdated
Comment thread Tests/L0Tests/DownloadManager/DownloadManager_LifecycleTests.cpp Outdated
Copilot AI review requested due to automatic review settings April 30, 2026 10:09
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Comment thread .github/workflows/L0-tests.yml Outdated
Comment thread .github/workflows/L0-tests.yml Outdated
Comment thread Tests/L0Tests/DownloadManager/ServiceMock.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants