SERXIONE-8617 Fix crash in AAMPGstPlayer::Pause when receiving EAS alert#1445
Draft
jfagunde wants to merge 1 commit into
Draft
SERXIONE-8617 Fix crash in AAMPGstPlayer::Pause when receiving EAS alert#1445jfagunde wants to merge 1 commit into
jfagunde wants to merge 1 commit into
Conversation
Reason for Change: Fix crash in AAMPGstPlayer::Pause Summary of Changes: - Add protection against null playerInstance to AAMPGstPlayer::Pause - Lock sync mutex in AAMPGstPlayer::Stop - Test changes in L1 tests - Add mocks for SyncBegin and SyncEnd Test Procedure: Send EAS alerts and confirm there is no crash Priority: P0 Risks: Low
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Change: Fix crash in AAMPGstPlayer::Pause
Summary of Changes:
Test Procedure: Send EAS alerts and confirm there is no crash
Priority: P0
Risks: Low