VPAAMP-242 l1test build failures after osx updates#1395
Open
pstroffolino wants to merge 6 commits intodev_sprint_25_2from
Open
VPAAMP-242 l1test build failures after osx updates#1395pstroffolino wants to merge 6 commits intodev_sprint_25_2from
pstroffolino wants to merge 6 commits intodev_sprint_25_2from
Conversation
Reason for change: If tuning before a fake tune has completed, the player can be left with
stale encrypted player pointers, potentially leading to a crash
Test Procedure: See ticket
Risks: low
Signed-off-by: James Lofthouse <james_lofthouse@comcast.com>
- Use g_autoptr(GstPad) in gstcdmidecryptor so all exit paths release sinkpad - Initialize aamp, mEncryptedAamp, mEncryptedAampId via member-initializer list in FakeAampGstPlayer ctor - Guard SetEncryptedHeaders to reject calls from non-active players in single-pipeline mode
…ted_player_stored
Reason for Change: Added OPENSSL_PKG=$(brew --prefix openssl)/lib/pkgconfig to the macOS cmake line in run.sh so that pkg_check_modules(OPENSSL REQUIRED openssl) in the L1 test CMake finds the Homebrew OpenSSL regardless of which patch version is installed. Using brew --prefix openssl (a stable symlink) means it won't break again on the next Homebrew OpenSSL upgrade. Risk: Low Signed-off-by: Philip Stroffolino <philip_stroffolino@cable.comcast.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the L1 unit test runner script on macOS to ensure CMake’s pkg_check_modules(OPENSSL REQUIRED openssl) can reliably locate the Homebrew OpenSSL pkg-config metadata after Homebrew OpenSSL upgrades.
Changes:
- Add a Homebrew-derived OpenSSL pkg-config directory to
PKG_CONFIG_PATHfor macOS builds intest/utests/run.sh.
- Replace bare 'brew --prefix openssl' with 'brew --prefix openssl@3' to match the repo's documented dependency and avoid ambiguity - Guard against formula not being installed: check for openssl.pc before appending to PKG_CONFIG_PATH, and emit a clear error with the install command if it is missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Change: Added OPENSSL_PKG=$(brew --prefix openssl)/lib/pkgconfig to the macOS cmake line in run.sh so that pkg_check_modules(OPENSSL REQUIRED openssl) in the L1 test CMake finds the Homebrew OpenSSL regardless of which patch version is installed. Using brew --prefix openssl (a stable symlink) means it won't break again on the next Homebrew OpenSSL upgrade.
Risk: Low
Test Guidance: l1 tests working on all platforms