Feature/vplay 13206 dev#1380
Open
molakalapalliharipriya wants to merge 3 commits intosupport/2.11.1_8.4_vipafrom
Open
Feature/vplay 13206 dev#1380molakalapalliharipriya wants to merge 3 commits intosupport/2.11.1_8.4_vipafrom
molakalapalliharipriya wants to merge 3 commits intosupport/2.11.1_8.4_vipafrom
Conversation
Reason for Change: When rewinding over VoD ad, it was played momentarily Summary of Changes: * In MonitorProgress(), call ReportAdProgress before PlayFromTsbStart Test Procedure: Rewind VoD asset over ads Priority: P1 Risks: Medium
Reason for change: Change the order of TuneHelper and MonitorProgress calls, so that progress event with position=0 will be sent before the AAMP starts playback at 1x speed to trigger the PPJS AdRewindController logic Test Procedure: As mentioned in the ticket Risks: High Signed-off-by: Vinish100 <vinish.balan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.