-
Notifications
You must be signed in to change notification settings - Fork 14
Development/covering missed tags & removing mock shell dependency #284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
smanes0213
wants to merge
33
commits into
master
Choose a base branch
from
development/Covering_Missed_Tags
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
dac8a34
Remove Mockshell dependency from JSONRPC Functional Tests
smanes0213 4f92c50
Merge branch 'master' into development/Remove_MockShell_Dependency
smanes0213 34186b3
Merge branch 'master' into development/Remove_MockShell_Dependency
smanes0213 88902ce
Resolve review comments
smanes0213 1d858df
Add new interface headers to add the missed flags and add respective …
smanes0213 797396f
Merge branch 'master' into development/Covering_Missed_Tags
smanes0213 40a31e3
Add implementation files and update CMake accordingly
smanes0213 4598ea8
refactor: split ITestJsonFormatting into per-interface files, add res…
smanes0213 695afd6
Resolve review comments
smanes0213 f968e7d
Potential fix for pull request finding
smanes0213 f6761ba
Potential fix for pull request finding
smanes0213 7e2a380
Potential fix for pull request finding
smanes0213 7792415
Potential fix for pull request finding
smanes0213 551f3f1
Potential fix for pull request finding
smanes0213 ef6b950
Resolve review comments
smanes0213 76794b6
Resolve test failure
smanes0213 e6ec66d
Resolve test failure
smanes0213 74c74fc
Add Jsonrpc functional tests
smanes0213 522a4c9
Resolve build failure
smanes0213 8f0880e
Resolve build failure
smanes0213 9d96547
Update the include path for JSONRPC.h
smanes0213 3175253
Update the include path for JSONRPC.h
smanes0213 3e7f0d9
Resolve test failure
smanes0213 9e06ccd
Potential fix for pull request finding
smanes0213 04a7a5f
Resolve review comments
smanes0213 6831e12
Resolve review comments
smanes0213 21fd51f
Resolve workflow error
smanes0213 90ff5ac
Resolve workflow error
smanes0213 22e3d23
Resolve copilot review comments
smanes0213 b9609dc
Merge branch 'master' into development/Covering_Missed_Tags
smanes0213 1982d31
Resolve workflow failure
smanes0213 05a7e08
Resolve workflow failure
smanes0213 4d69c52
Resolve workflow failure
smanes0213 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64 changes: 64 additions & 0 deletions
64
tests/FunctionalTests/common/implementations/TestEncodingMacImpl.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| /* | ||
| * If not stated otherwise in this file or this component's LICENSE file the | ||
| * following copyright and licenses apply: | ||
| * | ||
| * Copyright 2026 Metrological | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| #include <ImplementationFactory.h> | ||
| #include <ITestEncodingMac.h> | ||
| #include <cstring> | ||
|
|
||
| namespace Thunder { | ||
| namespace TestImplementation { | ||
|
|
||
| class TestEncodingMacImpl : public FunctionalTest::ITestEncodingMac { | ||
| public: | ||
| TestEncodingMacImpl() { memset(_mac, 0, sizeof(_mac)); } | ||
| ~TestEncodingMacImpl() override = default; | ||
|
|
||
| TestEncodingMacImpl(const TestEncodingMacImpl&) = delete; | ||
| TestEncodingMacImpl& operator=(const TestEncodingMacImpl&) = delete; | ||
|
|
||
| Core::hresult SetMacAddress(const uint8_t mac[]) override | ||
| { | ||
| memcpy(_mac, mac, 6); | ||
| return Core::ERROR_NONE; | ||
| } | ||
|
|
||
| Core::hresult GetMacAddress(uint8_t mac[]) const override | ||
| { | ||
| memcpy(mac, _mac, 6); | ||
| return Core::ERROR_NONE; | ||
| } | ||
|
|
||
| Core::hresult EchoMacAddress(const uint8_t input[], uint8_t output[]) const override | ||
| { | ||
| memcpy(output, input, 6); | ||
| return Core::ERROR_NONE; | ||
| } | ||
|
|
||
| BEGIN_INTERFACE_MAP(TestEncodingMacImpl) | ||
| INTERFACE_ENTRY(FunctionalTest::ITestEncodingMac) | ||
| END_INTERFACE_MAP | ||
|
|
||
| private: | ||
| uint8_t _mac[6]; | ||
| }; | ||
|
|
||
| static Factory::Registrar<FunctionalTest::ITestEncodingMac, TestEncodingMacImpl> g_encodingMacRegistrar; | ||
|
|
||
| } // namespace TestImplementation | ||
| } // namespace Thunder |
48 changes: 48 additions & 0 deletions
48
tests/FunctionalTests/common/implementations/TestJsonCompliantImpl.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| /* | ||
| * If not stated otherwise in this file or this component's LICENSE file the | ||
| * following copyright and licenses apply: | ||
| * | ||
| * Copyright 2026 Metrological | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| #include <ImplementationFactory.h> | ||
| #include <ITestJsonCompliant.h> | ||
|
|
||
| namespace Thunder { | ||
| namespace TestImplementation { | ||
|
|
||
| class TestJsonCompliantImpl : public FunctionalTest::ITestJsonCompliant { | ||
| public: | ||
| TestJsonCompliantImpl() = default; | ||
| ~TestJsonCompliantImpl() override = default; | ||
|
|
||
| TestJsonCompliantImpl(const TestJsonCompliantImpl&) = delete; | ||
| TestJsonCompliantImpl& operator=(const TestJsonCompliantImpl&) = delete; | ||
|
|
||
| Core::hresult Ping(const string& payload, string& reply) const override | ||
| { | ||
| reply = payload; | ||
| return Core::ERROR_NONE; | ||
| } | ||
|
|
||
| BEGIN_INTERFACE_MAP(TestJsonCompliantImpl) | ||
| INTERFACE_ENTRY(FunctionalTest::ITestJsonCompliant) | ||
| END_INTERFACE_MAP | ||
| }; | ||
|
|
||
| static Factory::Registrar<FunctionalTest::ITestJsonCompliant, TestJsonCompliantImpl> g_registrar; | ||
|
|
||
| } // namespace TestImplementation | ||
| } // namespace Thunder |
67 changes: 67 additions & 0 deletions
67
tests/FunctionalTests/common/implementations/TestJsonShapeImpl.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| /* | ||
| * If not stated otherwise in this file or this component's LICENSE file the | ||
| * following copyright and licenses apply: | ||
| * | ||
| * Copyright 2026 Metrological | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| #include <ImplementationFactory.h> | ||
| #include <ITestJsonShape.h> | ||
|
|
||
| namespace Thunder { | ||
| namespace TestImplementation { | ||
|
|
||
| class TestJsonShapeImpl : public FunctionalTest::ITestJsonShape { | ||
| public: | ||
| TestJsonShapeImpl() : _counter(42) {} | ||
| ~TestJsonShapeImpl() override = default; | ||
|
|
||
| TestJsonShapeImpl(const TestJsonShapeImpl&) = delete; | ||
| TestJsonShapeImpl& operator=(const TestJsonShapeImpl&) = delete; | ||
|
|
||
| Core::hresult GetWrappedCounter(uint32_t& counter) const override | ||
| { | ||
| counter = _counter; | ||
| return Core::ERROR_NONE; | ||
| } | ||
|
|
||
| Core::hresult EchoExtractedList( | ||
| const std::vector<uint32_t>& input, | ||
| std::vector<uint32_t>& output) const override | ||
| { | ||
| output = input; | ||
| return Core::ERROR_NONE; | ||
| } | ||
|
|
||
| Core::hresult EchoStruct( | ||
| const Dimensions& in, | ||
| Dimensions& out) const override | ||
| { | ||
| out = in; | ||
| return Core::ERROR_NONE; | ||
| } | ||
|
|
||
| BEGIN_INTERFACE_MAP(TestJsonShapeImpl) | ||
| INTERFACE_ENTRY(FunctionalTest::ITestJsonShape) | ||
| END_INTERFACE_MAP | ||
|
|
||
| private: | ||
| uint32_t _counter; | ||
| }; | ||
|
|
||
| static Factory::Registrar<FunctionalTest::ITestJsonShape, TestJsonShapeImpl> g_jsonShapeRegistrar; | ||
|
|
||
| } // namespace TestImplementation | ||
| } // namespace Thunder |
48 changes: 48 additions & 0 deletions
48
tests/FunctionalTests/common/implementations/TestJsonTextCaseImpl.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| /* | ||
| * If not stated otherwise in this file or this component's LICENSE file the | ||
| * following copyright and licenses apply: | ||
| * | ||
| * Copyright 2026 Metrological | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| #include <ImplementationFactory.h> | ||
| #include <ITestJsonTextCase.h> | ||
|
|
||
| namespace Thunder { | ||
| namespace TestImplementation { | ||
|
|
||
| class TestJsonTextCaseImpl : public FunctionalTest::ITestJsonTextCase { | ||
| public: | ||
| TestJsonTextCaseImpl() = default; | ||
| ~TestJsonTextCaseImpl() override = default; | ||
|
|
||
| TestJsonTextCaseImpl(const TestJsonTextCaseImpl&) = delete; | ||
| TestJsonTextCaseImpl& operator=(const TestJsonTextCaseImpl&) = delete; | ||
|
|
||
| Core::hresult EchoCaseConvention(const uint16_t sourceValue, uint16_t& resultValue) const override | ||
| { | ||
| resultValue = sourceValue; | ||
| return Core::ERROR_NONE; | ||
| } | ||
|
|
||
| BEGIN_INTERFACE_MAP(TestJsonTextCaseImpl) | ||
| INTERFACE_ENTRY(FunctionalTest::ITestJsonTextCase) | ||
| END_INTERFACE_MAP | ||
| }; | ||
|
|
||
| static Factory::Registrar<FunctionalTest::ITestJsonTextCase, TestJsonTextCaseImpl> g_registrar; | ||
|
|
||
| } // namespace TestImplementation | ||
| } // namespace Thunder |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.