[Actions] Make sure new files will not be missed in the diff#277
Merged
Conversation
LuaGenerator ResultsChanges detected. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates several generator GitHub Actions workflows to produce directory diffs using diff -rN -U5 (instead of git diff --no-index) and to stage baselines in locally-named directories so the resulting diff headers are cleaner and include newly added files.
Changes:
- Replace
git diff --no-indexwithdiff -rN -U5to include full patches for files that exist only on the generated side. - Copy the gh-pages baseline into a local
baselinedirectory (or create an empty baseline dir) before diffing, to avoid absolute paths in diff headers. - Apply the same diffing approach across ProxyStubGenerator, LuaGenerator, JsonGenerator, and PluginSkeletonGenerator workflows.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/ProxyStubGenerator.yml | Switch directory diff generation to diff -rN -U5 with a locally staged baseline directory. |
| .github/workflows/PluginSkeletonGenerator.yml | Switch per-variant diffs to diff -rN -U5 after copying baseline locally (per variant). |
| .github/workflows/LuaGenerator.yml | Switch directory diff generation to diff -rN -U5 with a locally staged baseline directory. |
| .github/workflows/JsonGenerator.yml | Switch directory diff generation to diff -rN -U5 with a locally staged baseline directory. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JsonGenerator ResultsChanges detected. |
ProxyStubGenerator ResultsChanges detected. |
sebaszm
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.