RDKBWIFI-445: Fixed binary data comparison in webconfig#1144
Open
vlad-safonov wants to merge 2 commits into
Open
RDKBWIFI-445: Fixed binary data comparison in webconfig#1144vlad-safonov wants to merge 2 commits into
vlad-safonov wants to merge 2 commits into
Conversation
github-actions
Bot
added
the
community contribution
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: AP metric report shows statistic for all VAP's from first VAP including the STA report
After investigation we found binary data comparing using strncmp, mac is starting with
0, treaded as comparison of two 0-length strings and always returning trueTest procedure: AP metric report should statistic for correct VAP
After STA connection statistic should be available only on one VAP
(without the patch it will be shown on all VAP's)
bez patcha STA pokazivajetsja na vseh vapah
Priority: Critical
Risk: Low