RDKBWIFI-442: Beacon measurements collection from the associated STA

[Nikita-Hakai]

Collection of Beacon measurement report from the associated STA

[Copilot]

Pull request overview

Adds EasyMesh beacon-query/report plumbing so the EM app can request beacon measurements from associated STAs, process RRM measurement reports, encode/decode beacon report payloads, and translate them into EasyMesh STA info.

Changes:

• Adds Device.WiFi.EM.BeaconQuery handling and RRM action-frame send/receive paths.
• Changes beacon report payload storage from a fixed array to dynamically allocated data.
• Updates beacon report encoding/decoding and EasyMesh translation logic.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
source/webconfig/wifi_webconfig_beacon_report.c	Frees prior dynamic beacon report data before decoding a new report.
source/webconfig/wifi_encoder.c	Dynamically allocates the hex string used to encode report data.
source/webconfig/wifi_easymesh_translator.c	Finds BSS by vap_index and copies beacon report data into EasyMesh STA info.
source/webconfig/wifi_decoder.c	Allocates beacon report data from decoded FrameLen and decodes hex report data.
source/core/wifi_ctrl.c	Routes radio measurement action frames to the beacon report event subtype.
source/apps/em/wifi_em.h	Adds beacon query namespace and EM data fields.
source/apps/em/wifi_em.c	Adds beacon query sending, RRM beacon report parsing/publishing, and bus registration.
include/wifi_base.h	Adds beacon query params and changes beacon report data to a pointer.

Comments suppressed due to low confidence (4)

source/apps/em/wifi_em.c:935

• The HAL result is ignored. If wifi_hal_setRMBeaconRequest fails, the function still logs a dialog token and returns success, so the controller gets no indication that the beacon request was not transmitted.

    wifi_hal_setRMBeaconRequest(ap_index, query->sta_mac, params, &out_dialog);
    wifi_util_dbg_print(WIFI_EM, "%s:%d: dialogue token is %d\n", __func__, __LINE__, out_dialog);

source/webconfig/wifi_decoder.c:6284

• This new allocation is not released by the generic webconfig_data_free cleanup path, which currently only frees u.encoded.raw. Successful beacon-report decodes will therefore leak the report buffer unless this ownership is added to cleanup or freed after translation.

    sta_data->data = (unsigned char *)malloc(sta_data->data_len);
    if (sta_data->data == NULL) {
        wifi_util_error_print(WIFI_WEBCONFIG, "%s:%d: failed to allocate %u bytes for report data\n",
            __func__, __LINE__, sta_data->data_len);
        return webconfig_error_decode;

source/webconfig/wifi_decoder.c:6287

• If ReportData is missing or invalid, decode_param_string returns immediately from the function and bypasses the free for sta_data->data, leaking the buffer allocated above.

    decode_param_string(obj_sta_cfg, "ReportData", param);

source/webconfig/wifi_decoder.c:6289

• stringtohex only checks that the output buffer is large enough for the input string; it does not require ReportData to contain exactly FrameLen * 2 hex characters. With the new malloc'd buffer, a short hex string leaves the remaining bytes uninitialized and those bytes can be forwarded/encoded as part of the report.

    out_ptr = stringtohex(strlen(param->valuestring), param->valuestring, sta_data->data_len,
        sta_data->data);

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 9 comments.