thread fix#7
Open
ellemenno wants to merge 5 commits into
Open
Conversation
following recommendation in discussion on rcolyer#3 : rcolyer#3 (comment)
lestrrat
added a commit
to lestrrat-go/openscad
that referenced
this pull request
Jul 7, 2023
|
Does this mean I just started a print where my internal and external threads aren't going to mesh? |
|
After that print finished, the threads didn't mesh. I pulled in @ellemenno 's changes and reprinted and the threads still didn't mesh but they were a little better. I'm assuming the issue I'm having is related to the precision of my printer so I'm just increasing the diameter of the internal threads by 2%. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr just repackages the fix and test submitted by @nobodyinperson (thank you!), and applies the edit requested by @rcolyer, so it can hopefully be merged. having meshing internal and external threads is pretty important!