[refactor][2/N] Move UnmarshalRuntimeEnvYAML to utils.go

[owenowenisme]

Why are these changes needed?

UnmarshalRuntimeEnvYAML doesn't depend on dashboard_httpvlient, so move to utils.go

Related issue number

Checks

• I've made sure the tests are passing.
• Testing Strategy
  • Unit tests
  • Manual tests
  • This PR is not tested :(

[kevin85421]

Based on our discussion yesterday, we should not move UmarshalRuntimeEnvYAML to util.go in order to avoid importing ray/utils (which also imports controller-runtime) into dashboard_httpclient.go.

[owenowenisme]

@kevin85421 Sorry I got mixed up, but after second thought, validation.go also use UmarshalRuntimeEnvYAML, and since we will eventually make dashboard_httpclient a new package, it will be weird to import dashboard_httpclient for
UmarshalRuntimeEnvYAML.
Are we going to separate a new package for functions like this (light-weight dependencies functions)?

kuberay/ray-operator/controllers/ray/utils/validation.go

Lines 193 to 198 in edf7de8

	if _, err := UnmarshalRuntimeEnvYAML(rayJob.Spec.RuntimeEnvYAML); err != nil {
	return err
	}
	if rayJob.Spec.ActiveDeadlineSeconds != nil && *rayJob.Spec.ActiveDeadlineSeconds <= 0 {
	return fmt.Errorf("activeDeadlineSeconds must be a positive integer")
	}

[kevin85421]

How about moving type RuntimeEnvType map[string]interface{} to rayjob_types.go, then removing UnmarshalRuntimeEnvYAML and using yaml.Unmarshal directly in case UnmarshalRuntimeEnvYAML is very short and simple?

[owenowenisme]

How about moving type RuntimeEnvType map[string]interface{} to rayjob_types.go, then removing UnmarshalRuntimeEnvYAML and using yaml.Unmarshal directly in case UnmarshalRuntimeEnvYAML is very short and simple?

@kevin85421, How about moving it to utiltypes package as we are going to create a new package in #3979, I prefer not to modify rayJob_type for this and also code-gen will give error if we put that type there.
Updated in e9d9f0d

github.com/ray-project/kuberay/ray-operator/apis/ray/v1:-: invalid map value type: interface{}