[Flaky] Test Autoscaler E2E Part 2 (nightly operator) is flaky #3954
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Wu <[email protected]>
popojk
changed the title
There was a problem hiding this comment.
There’s an issue #3909 regarding the scaling speed (I think @Future-Outlier is working on that). Maybe we should wait for it to be resolved before changing the timeout value?
Hi @owenowenisme , thanks for pointing this out! Yes, it makes sense to wait until the scaling speed PR is completed first. cc @win5923 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The current e2e test
raycluster_autoscaler_part2_testis flaky. In the test case TestRayClusterAutoscalerV2IdleTimeout, logs show that the autoscaler takes ~84 seconds to scale down(10 seconds idle + 74 seconds scale down), whereas the test script sets a 40-second timeout(10 seconds idle + 30 seconds buffer), causing failures. This PR increases the timeout buffer from 30 seconds to 100 seconds to reduce flakiness.Related issue number
Closes #3940
Checks