Skip to content

Conversation

@Danielle9897
Copy link
Member

@Danielle9897 Danielle9897 requested a review from M4xymm January 12, 2026 18:32
Comment on lines 337 to 340
this.vectorField("vectorFromTextEmbeddings", {
// Vector options can be customized
// in the same way as the above index example.
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sourceEmbeddingType and destinationEmbeddingType are required.

Suggested change
this.vectorField("vectorFromTextEmbeddings", {
// Vector options can be customized
// in the same way as the above index example.
});
this.vectorField("vectorFromTextEmbeddings", {
// Vector options can be customized
// in the same way as the above index example.
sourceEmbeddingType: "Single", destinationEmbeddingType: "Single"
})

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment on lines 363 to 366
"vectorFromTextEmbeddings": {
// Vector options can be customized
// in the same way as the above index example.
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"vectorFromTextEmbeddings": {
// Vector options can be customized
// in the same way as the above index example.
}
"vectorFromTextEmbeddings": {
// Vector options can be customized
// in the same way as the above index example.
vector: {
sourceEmbeddingType: "Single", destinationEmbeddingType: "Single"
}
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

queryVector => queryVector
// Call 'byEmbedding'
// Provide the vector for the similarity comparison
.byEmbedding([6.599999904632568, 7.699999809265137])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.byEmbedding([6.599999904632568, 7.699999809265137])
.byEmbedding(RavenVector([6.599999904632568, 7.699999809265137])

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

.rawQuery(`
from index "Movies/ByVector/Single"
where vector.search(vectorFromSingle, $queryVector)`)
.addParameter("queryVector", [6.599999904632568, 7.699999809265137])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.addParameter("queryVector", [6.599999904632568, 7.699999809265137])
.addParameter("queryVector", RavenVector([6.599999904632568, 7.699999809265137])

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@Danielle9897 Danielle9897 requested a review from M4xymm January 14, 2026 13:18
@ppekrol ppekrol merged commit 6c4704d into ravendb:main Jan 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants