-
Notifications
You must be signed in to change notification settings - Fork 64
Make final discontinuation changes #1169
Make final discontinuation changes #1169
Conversation
jameslamb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I've understood the plan correctly, I think we also need to update the version here:
Lines 22 to 26 in 51f87cd
| # The full version, including alpha/beta/rc tags. | |
| from ucp import __version__ as release | |
| # The short X.Y version. | |
| version = ".".join(release.split(".")[:2]) |
To a hard-coded:
version = "0.45.0"Otherwise, when we merge this branch to main and build docs from there, the docs will say 0.46.0 for the version wherever Sphinx puts it, like in the tab titles:
docs/source/install.rst
Outdated
| pip install 'libucx-cu13>=1.19.0,<1.20' | ||
|
|
||
| # CUDA 12 | ||
| pip install 'libucx-cu12>=1.19.0,<1.20' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're not planning to release ucx-py-cu12==0.46, anyone running these instructions will get ucx-py-cu12==0.45.
ucx-py-cu12==0.45 packages are pinned to not allow UCX 1.19:
Line 197 in d0a58d3
| - libucx-cu12>=1.15.0,<1.19 |
So I think something needs to be done here.
If the plan is to merge this into branch-0.46 and then branch-0.46 into main and then archive the repo, and for these docs to be the ones users find at https://ucx-py.readthedocs.io/en/latest/, then I think we need to also revert any docs changes about UCX 1.19, back to the range support by 0.45.
I think you may just want to do this on your PR branch:
git checkout branch-0.45 -- docs/And then just manually re-add the warning added in #1167
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now I understand your point, previously I thought about this but thought it wasn't necessary because we can support 1.19.0, but I didn't think about pins in the 0.45 packages.
README.md
Outdated
| > [!WARNING] | ||
| > UCX-Py is deprecated and will be phased out soon, version 0.45 (RAPIDS 25.08) is expected to be the last release. Projects that rely on UCX-Py are advised to migrate to [UCXX](https://github.com/rapidsai/ucxx) immediately. | ||
| > [!CAUTION] | ||
| > UCX-Py has been discontinued, version 0.45 (RAPIDS 25.08) was its last release and it will receive no further updates. Projects depending on UCX-Py are advised to migrate to [UCXX](https://github.com/rapidsai/ucxx) immediately. [UCXX documentation](https://docs.rapids.ai/api/ucxx/nightly/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| > UCX-Py has been discontinued, version 0.45 (RAPIDS 25.08) was its last release and it will receive no further updates. Projects depending on UCX-Py are advised to migrate to [UCXX](https://github.com/rapidsai/ucxx) immediately. [UCXX documentation](https://docs.rapids.ai/api/ucxx/nightly/). | |
| > UCX-Py has been discontinued, version 0.45 (RAPIDS 25.08) was its last release and it will receive no further updates. Projects depending on UCX-Py are advised to migrate to [UCXX](https://github.com/rapidsai/ucxx) immediately. [UCXX documentation](https://docs.rapids.ai/api/ucxx/nightly/). For more details, see https://docs.rapids.ai/notices/rsn0050/. |
I think we should add a link to the RSN. That's helpful in teaching RAPIDS users that that's a section of the docs they should watch for breaking changes like this.
I've been doing that elsewhere, for that reason:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done with a slightly reorder in phrasing, see 64f73f8, let me know if you prefer your phrasing/ordering instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks totally fine to me, all I cared about is getting the RSN link in there somewhere. Thanks!
You're right, sorry I forgot about this! |
|
Thanks @jameslamb , I think I've addressed everything now, please have another look when you have a chance. |
jameslamb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are looking good to me, thank you!
|
Just realized one more thing that we want to change, which is the minimum UCX version, which is 1.15.0 in 0.45. Applied that change now in 4e88e63 . |
|
/merge |
This is expected to be the last commit to UCX-Py. It updates the README and docs warnings to inform users that UCX-Py has been permanently discontinued. Along with it, this change removes CUDA 13 mentions from docs, since there will be no CUDA 13 packages released for UCX-Py, however, the functional changes to allow building with CUDA 13 are kept should those be needed for any reason in the near-term.