Skip to content

Only use functions in the limited API #1545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 30, 2024
Merged

Only use functions in the limited API #1545

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
376c42f
Only use functions in the limited API
vyasr Apr 26, 2024
26839e3
Apply suggestions from code review
vyasr Apr 30, 2024
731214f
Merge branch 'branch-24.06' into feat/py_limited_api_compat
jakirkham Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions python/rmm/rmm/_lib/device_buffer.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
import numpy as np

cimport cython
from cpython.bytes cimport PyBytes_AS_STRING, PyBytes_FromStringAndSize
from cpython.bytes cimport PyBytes_AsString, PyBytes_FromStringAndSize
from libc.stdint cimport uintptr_t
from libcpp.memory cimport unique_ptr
from libcpp.utility cimport move
Expand Down Expand Up @@ -314,7 +314,7 @@ cdef class DeviceBuffer:
cdef size_t s = dbp.size()

cdef bytes b = PyBytes_FromStringAndSize(NULL, s)
cdef unsigned char* p = <unsigned char*>PyBytes_AS_STRING(b)
cdef unsigned char* p = <unsigned char*>PyBytes_AsString(b)
cdef unsigned char[::1] mv = (<unsigned char[:(s + 1):1]>p)[:s]
self.copy_to_host(mv, stream)

Expand Down