Allow CMake v4+ #669
Allow CMake v4+ #669
Conversation
trxcllnt
added
improvement
| - clang==20.1.4 | ||
| - click >=8.1 | ||
| - cmake>=3.30.4,<4 | ||
| - cmake>=3.30.4 |
There was a problem hiding this comment.
We occasionally have to do a dance when a cmake minor/point release is made because something has broken/rapids-cmake needs an update.
Can we upper-bound to currently known working 4.x versions?
There was a problem hiding this comment.
I made this align with the other RAPIDS repos. I think they don't pin to an upper bound because we want to pick up new features, @robertmaynard may have more insight.
There was a problem hiding this comment.
As far as I am aware RAPIDS works with any 4.X release so we are safe
There was a problem hiding this comment.
Previous times when we needed to upper bound pin (via cursory search)
- [BUG][JNI] conda-java-tests fail to build thrift cudf#18391
- Pin CMake to prevent 3.23 bugs cudf#10544
With no upper bound pin, on any future date we can arbitrarily break with no forewarning.
Although cmake is not the most frequent culprit here, removing an upper bound pin introduces one more place where it might happen.
3 participants
Support building with CMake v4+ to align with other RAPIDS repos.
This is required for NVAIE/DLFW builds of RAPIDS v25.12.