TPCH-derived Q9 #663
Open
TPCH-derived Q9 #663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wence-
added
improvement
wence-
force-pushed
the
wence/fea/streaming-examples
branch
3 times, most recently
from
9ca765b to
d8e9cb3
Compare
wence-
force-pushed
the
wence/fea/streaming-examples
branch
3 times, most recently
from
bebd8a7 to
5c24230
Compare
wence-
force-pushed
the
wence/fea/streaming-examples
branch
from
c12a5c8 to
1c7735c
Compare
wence-
force-pushed
the
wence/fea/streaming-examples
branch
from
1c7735c to
8f99472
Compare
TomAugspurger
approved these changes
Nov 24, 2025
| auto chunk = | ||
| rapidsmpf::ndsh::to_device(ctx, msg.release<rapidsmpf::streaming::TableChunk>()); | ||
| auto table = chunk.table_view(); | ||
| auto rounded = cudf::round( |
Contributor
There was a problem hiding this comment.
I get a warning here when compiling:
/home/nfs/toaugspurger/gh/rapidsai/rapidsmpf/cpp/benchmarks/streaming/ndsh/q09.cpp: In function 'rapidsmpf::streaming::Node {anonymous}::sort_by(std::shared_ptr<rapidsmpf::streaming::Context>, std::shared_ptr<rapidsmpf::streaming::Channel>, std::shared_ptr<rapidsmpf::streaming::Channel>)':
/home/nfs/toaugspurger/gh/rapidsai/rapidsmpf/cpp/benchmarks/streaming/ndsh/q09.cpp:480:31: warning: 'std::unique_ptr<cudf::column> cudf::round(const column_view&, int32_t, rounding_method, rmm::cuda_stream_view, rmm::device_async_resource_ref)' is deprecated [-Wdeprecated-declarations]
480 | auto rounded = cudf::round(
| ~~~~~~~~~~~^
481 | table.column(2),
| ~~~~~~~~~~~~~~~~
482 | 2,
| ~~
483 | cudf::rounding_method::HALF_EVEN,
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
484 | chunk.stream(),
| ~~~~~~~~~~~~~~~
485 | ctx->br()->device_mr()
| ~~~~~~~~~~~~~~~~~~~~~~
486 | );
| ~
In file included from /home/nfs/toaugspurger/gh/rapidsai/rapidsmpf/cpp/benchmarks/streaming/ndsh/q09.cpp:23:
/raid/toaugspurger/envs/rapidsmpf-dev/include/cudf/round.hpp:66:40: note: declared here
66 | [[deprecated]] std::unique_ptr<column> round(
Contributor
There was a problem hiding this comment.
Maybe round_decimal is the replacement: https://docs.rapids.ai/api/libcudf/legacy/group__transformation__unaryops#gab4e78baedf16a1b627d81c07fd2032ac
Contributor
Author
There was a problem hiding this comment.
yes, but that needs a cast to and from which I haven't done.
I think the deprecation was a mistake but I wasn't convincing enough
| auto supplier_x_part_x_partsupp_x_lineitem_shuffled = | ||
| ctx->create_channel(); | ||
| auto orders_shuffled = ctx->create_channel(); | ||
| // TODO: |
Contributor
There was a problem hiding this comment.
Should it be clear what the TODO is? :) Maybe configurable number of partitions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that all the pieces are in, let's start putting the examples in.