Skip to content

Default to static linking of libcudart #885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 4 commits into from
Dec 11, 2025
Merged

Default to static linking of libcudart #885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4d12aca
Default to static linking of libcudart
bdice Dec 9, 2025
fd7976f
Remove CUDA_STATIC_RUNTIME from python/libkvikio/CMakeLists.txt
bdice Dec 9, 2025
18719c4
Use CUDA::cudart_static
bdice Dec 9, 2025
5ebbe7e
Remove cuda-cudart-dev dependencies
bdice Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions conda/recipes/kvikio/recipe.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,18 +85,15 @@ requirements:
- python =${{ py_version }}
- rapids-build-backend >=0.4.0,<0.5.0
- scikit-build-core >=0.10.0
- cuda-cudart-dev
run:
- ${{ pin_compatible("cuda-version", upper_bound="x", lower_bound="x") }}
- cupy >=13.6.0
- libkvikio =${{ version }}
- numpy >=1.23,<3.0
- packaging
- python
- cuda-cudart
ignore_run_exports:
by_name:
- cuda-cudart
- cuda-version
- libcurl
- libkvikio
Expand Down
3 changes: 0 additions & 3 deletions conda/recipes/libkvikio/recipe.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,6 @@ outputs:
host:
- ${{ pin_subpackage("libkvikio", exact=True) }}
- cuda-version =${{ cuda_version }}
- cuda-cudart-dev
- libcurl ==${{ libcurl_version }}
- libcufile-dev
run:
Expand All @@ -140,10 +139,8 @@ outputs:
- ${{ pin_compatible("cuda-version", upper_bound="x", lower_bound="x") }}
else:
- ${{ pin_compatible("cuda-version", upper_bound="x", lower_bound="12.2.0a0") }}
- cuda-cudart
ignore_run_exports:
by_name:
- cuda-cudart
- cuda-version
- libnuma
- libcufile
Expand Down
2 changes: 1 addition & 1 deletion cpp/examples/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ set(TEST_INSTALL_PATH bin/tests/libkvikio)
if(CUDAToolkit_FOUND)
add_executable(BASIC_IO_EXAMPLE basic_io.cpp)
set_target_properties(BASIC_IO_EXAMPLE PROPERTIES INSTALL_RPATH "\$ORIGIN/../../../lib")
target_link_libraries(BASIC_IO_EXAMPLE PRIVATE kvikio::kvikio CUDA::cudart)
target_link_libraries(BASIC_IO_EXAMPLE PRIVATE kvikio::kvikio CUDA::cudart_static)

if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
set(KVIKIO_CXX_FLAGS "-Wall;-Werror;-Wno-unknown-pragmas")
Expand Down
5 changes: 3 additions & 2 deletions cpp/tests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,9 @@ function(kvikio_add_test)
CUDA_STANDARD_REQUIRED ON
)
target_link_libraries(
${_KVIKIO_NAME} PRIVATE kvikio::kvikio GTest::gmock GTest::gmock_main GTest::gtest
GTest::gtest_main CUDA::cudart $<TARGET_NAME_IF_EXISTS:CURL::libcurl>
${_KVIKIO_NAME}
PRIVATE kvikio::kvikio GTest::gmock GTest::gmock_main GTest::gtest GTest::gtest_main
CUDA::cudart_static $<TARGET_NAME_IF_EXISTS:CURL::libcurl>
)

rapids_test_add(
Expand Down
2 changes: 0 additions & 2 deletions python/libkvikio/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,4 @@ set(KvikIO_BUILD_BENCHMARKS OFF)
set(KvikIO_BUILD_EXAMPLES OFF)
set(KvikIO_BUILD_TESTS OFF)

set(CUDA_STATIC_RUNTIME ON)

add_subdirectory(../../cpp kvikio-cpp)