Skip to content

Conversation

@kingcrimsontianyu
Copy link
Contributor

No description provided.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Sep 15, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@kingcrimsontianyu
Copy link
Contributor Author

/ok to test

@kingcrimsontianyu kingcrimsontianyu added non-breaking Introduces a non-breaking change Needs build-infra Requires input from the build infrastructure team improvement Improves an existing functionality labels Sep 15, 2025
@TomAugspurger
Copy link
Contributor

I've rerun my manual test from #823, and it still fails on this branch unfortunately.

I've also tried to add a moto-based unit test:

def test_read_with_special_characters(s3_base):
    bucket_name = "bucket"
    object_name = "date=2025-09-15"
    data = b"file content"
    with s3_context(
        s3_base=s3_base, bucket=bucket_name, files={object_name: bytes(data)}
    ) as server_address:
        with kvikio.RemoteFile.open_s3_url(f"s3://{bucket_name}/{object_name}") as f:
            assert f.nbytes() == len(data)
            got = bytearray(len(data))
            assert f.read(got) == len(got)

Unfortunately, it doesn't fail on branch-25.10 or this branch. So however moto is handling tokens, it isn't emulating this portion the same as S3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DO NOT MERGE improvement Improves an existing functionality Needs build-infra Requires input from the build infrastructure team non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants