-
Notifications
You must be signed in to change notification settings - Fork 82
Add C++ benchmarks (part 1/n) #659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
098be83 to
858b2f8
Compare
KyleFromNVIDIA
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few small CMake issues that should be fixed.
|
Thanks @kingcrimsontianyu this is a great start! I think the "Time" column makes sense to me, showing an optimum of 8 threads in both the weak and strong scaling cases. The "CPU" column doesn't make much sense to me though. |
mhaseeb123
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would appreciate some comments in threadpool_benchmark.cpp
|
@GregoryKimball |
madsbk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great
|
To avoid confusion, explanation of the metrics is added to the result in another ongoing PR (#664). |
Co-authored-by: Kyle Edwards <[email protected]>
Co-authored-by: Kyle Edwards <[email protected]>
Co-authored-by: Kyle Edwards <[email protected]>
Co-authored-by: Kyle Edwards <[email protected]>
Co-authored-by: Kyle Edwards <[email protected]>
Co-authored-by: Mads R. B. Kristensen <[email protected]>
2a3f76f to
3f3a620
Compare
mhaseeb123
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving C++ changes
|
/merge |

Partially addresses #606
This PR kick-starts the process of adding benchmarks to KvikIO. The following tasks are done:
To build and run the benchmark programs in the dev container:
Sample output: