Common knn graph build params #949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinsolp
added
non-breaking
cjnolet
reviewed
May 28, 2025
| @@ -0,0 +1,78 @@ | |||
| /* | |||
There was a problem hiding this comment.
cuVS isn't header-only, so the header files are very lightweight. Instead of introducing new headers for structs and enums, can we just reuse common.hpp?
There was a problem hiding this comment.
common.hpp has the base index_params (link), so declaring graph_build_params in that file results in a circular dependency (because we make use of ivf_pq::index_params and nn_descent::index_params inside `graph_build_params)
lowener
reviewed
Jun 4, 2025
|
@lowener Changed defaults. Ready for another round of reviews : ) |
|
This is ready to merge if there are no further suggestions! |
|
/merge |
github-project-automation
bot
moved this from In Progress
to Done
in Vector Search, ML, & Data Mining Release Board
This was referenced Jun 27, 2025
divyegala
added
breaking
rapids-bot bot
pushed a commit
that referenced
this pull request
Jun 27, 2025
…#1060) Fix to make #949 a non-breaking change. Authors: - Jinsol Park (https://github.com/jinsolp) Approvers: - Divye Gala (https://github.com/divyegala) URL: #1060
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reusing graph build params for cagra and all neighbors.
Related issue: #931