-
Notifications
You must be signed in to change notification settings - Fork 117
Instantiate only specific RAFT reduction kernels #925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertmaynard
approved these changes
Jun 2, 2025
cjnolet
approved these changes
Jun 5, 2025
msarahan
approved these changes
Jun 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved aside from revert comments
jakirkham
approved these changes
Jun 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Divye! 🙏
/merge |
rapids-bot bot
pushed a commit
to rapidsai/cuml
that referenced
this pull request
Jun 12, 2025
Depends on rapidsai/raft#2679, rapidsai/cumlprims_mg#263, and rapidsai/cuvs#925 with reference issue rapidsai/raft#2681. This reduces the CUDA 12 binary size of `libcuml++.so`by 11 MB from ~286 MB to ~275 MB. Authors: - Divye Gala (https://github.com/divyegala) Approvers: - Robert Maynard (https://github.com/robertmaynard) - Dante Gama Dessavre (https://github.com/dantegd) - Mike Sarahan (https://github.com/msarahan) URL: #6780
bkarsin
pushed a commit
to bkarsin/cuvs
that referenced
this pull request
Jun 19, 2025
Depends on rapidsai/raft#2679 with reference issue rapidsai/raft#2681. This PR reduces the wheel size from 936.9 MB to 917.1 MB. Authors: - Divye Gala (https://github.com/divyegala) - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Robert Maynard (https://github.com/robertmaynard) - Corey J. Nolet (https://github.com/cjnolet) - Mike Sarahan (https://github.com/msarahan) - https://github.com/jakirkham URL: rapidsai#925
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CMake
cpp
improvement
Improves an existing functionality
non-breaking
Introduces a non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on rapidsai/raft#2679 with reference issue rapidsai/raft#2681.
This PR reduces the wheel size from 914 MB to 892.3 MB.