Skip to content

Instantiate only specific RAFT reduction kernels #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 12, 2025

Conversation

divyegala
Copy link
Member

@divyegala divyegala commented May 22, 2025

Depends on rapidsai/raft#2679 with reference issue rapidsai/raft#2681.

This PR reduces the wheel size from 914 MB to 892.3 MB.

@divyegala divyegala self-assigned this May 22, 2025
@divyegala divyegala requested review from a team as code owners May 22, 2025 20:12
@divyegala divyegala added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels May 22, 2025
@divyegala divyegala requested a review from a team as a code owner May 28, 2025 05:10
@divyegala divyegala requested a review from AyodeAwe May 28, 2025 05:10
Copy link
Contributor

@msarahan msarahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved aside from revert comments

Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Divye! 🙏

@divyegala
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 8e76699 into rapidsai:branch-25.08 Jun 12, 2025
71 of 78 checks passed
rapids-bot bot pushed a commit to rapidsai/cuml that referenced this pull request Jun 12, 2025
Depends on rapidsai/raft#2679, rapidsai/cumlprims_mg#263, and rapidsai/cuvs#925 with reference issue rapidsai/raft#2681.

This reduces the CUDA 12 binary size of `libcuml++.so`by 11 MB from ~286 MB to ~275 MB.

Authors:
  - Divye Gala (https://github.com/divyegala)

Approvers:
  - Robert Maynard (https://github.com/robertmaynard)
  - Dante Gama Dessavre (https://github.com/dantegd)
  - Mike Sarahan (https://github.com/msarahan)

URL: #6780
bkarsin pushed a commit to bkarsin/cuvs that referenced this pull request Jun 19, 2025
Depends on rapidsai/raft#2679 with reference issue rapidsai/raft#2681.

This PR reduces the wheel size from 936.9 MB to 917.1 MB.

Authors:
  - Divye Gala (https://github.com/divyegala)
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Robert Maynard (https://github.com/robertmaynard)
  - Corey J. Nolet (https://github.com/cjnolet)
  - Mike Sarahan (https://github.com/msarahan)
  - https://github.com/jakirkham

URL: rapidsai#925
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake cpp improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants