Remove duplicate VPQ code of scann #1505
Open
+69
−106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mickael Ide <[email protected]>
github-project-automation
bot
moved this to Todo
in Vector Search, ML, & Data Mining Release Board
lowener
added
improvement
divyegala
requested changes
Nov 6, 2025
Member
divyegala
left a comment
divyegala
left a comment
There was a problem hiding this comment.
Can we compile this kernel once only and have both places call the same instance?
Signed-off-by: Mickael Ide <[email protected]>
divyegala
approved these changes
Nov 7, 2025
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scann is using
process_and_fill_codes_subspacesbut this code is already present invpq_dataset.cuh.The code in
vpq_dataset.cuhis more recent because it supports batching.This PR removes the duplicated code.