Skip to content

Temporarily remove xgboost from test dependencies. #7523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Temporarily remove xgboost from test dependencies. #7523

wants to merge 5 commits into from

Conversation

@csadorf
Copy link
Contributor

@csadorf csadorf commented Nov 20, 2025

While we work on resolving #7520

@csadorf csadorf requested a review from a team as a code owner November 20, 2025 19:25
@csadorf csadorf requested a review from bdice November 20, 2025 19:25
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Nov 20, 2025
@csadorf csadorf added bug Something isn't working non-breaking Non-breaking change labels Nov 20, 2025
@csadorf csadorf requested a review from a team as a code owner November 20, 2025 19:48
@csadorf csadorf mentioned this pull request Nov 20, 2025
Open
@jcrist
Copy link
Member

jcrist commented Nov 20, 2025

Looks like rapidsai/raft#2813 snuck in before this completed, which is why the devcontainer build is failing. We'll need to update to the new apis for knn (we're trying to load ann.cuh at least, which has been removed, there may be more beyond that).

@csadorf
Copy link
Contributor Author

csadorf commented Nov 20, 2025

Looks like rapidsai/raft#2813 snuck in before this completed, which is why the devcontainer build is failing. We'll need to update to the new apis for knn (we're trying to load ann.cuh at least, which has been removed, there may be more beyond that).

I'll introduce a patch for that.

@csadorf csadorf requested review from a team as code owners November 21, 2025 15:53
@csadorf csadorf requested a review from dantegd November 21, 2025 15:53
@csadorf csadorf added the DO NOT MERGE Hold off on merging; see PR for details label Nov 21, 2025
@jcrist jcrist mentioned this pull request Nov 21, 2025
Merged
@jcrist
Copy link
Member

jcrist commented Nov 21, 2025

We'll need to apply this to release/25.12 as well (and fixup a few things). Superseded by #7526, closing.

@jcrist jcrist closed this Nov 21, 2025
rapids-bot bot pushed a commit that referenced this pull request Nov 21, 2025
@jcrist
Temporarily drop xgboost from CI (#7526)
386109d 
Dropping xgboost from our CI for now while upstream builds are fixed.

Stopgap for #7520. Supersedes #7523.

Authors:
  - Jim Crist-Harif (https://github.com/jcrist)

Approvers:
  - https://github.com/jakirkham

URL: #7526
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bdice bdice bdice approved these changes

@dantegd dantegd Awaiting requested review from dantegd dantegd is a code owner automatically assigned from rapidsai/cuml-cmake-codeowners

Assignees

@csadorf csadorf

Labels

bug Something isn't working CMake conda conda issue CUDA/C++ Cython / Python Cython or Python issue DO NOT MERGE Hold off on merging; see PR for details non-breaking Non-breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@csadorf @jcrist @bdice