Remove target_dtype and supporting infra
#7516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was only ever called to set the output type, easier to delete and just use `_set_output_type` directly.
jcrist
added
improvement
aamijar
approved these changes
Nov 20, 2025
Member
aamijar
left a comment
aamijar
left a comment
There was a problem hiding this comment.
Should we update the wiki?
cuml/wiki/python/ESTIMATOR_GUIDE.md
Line 752 in b603d65
Member
Author
|
Looks like a lot of that doc is out of date. I'd prefer to handle that in a followup, it's more than just ripping out |
csadorf
approved these changes
Nov 20, 2025
Member
Author
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With all the work in #7317, we're now at a point where
target_dtypeis no longer used.This PR removes
target_dtypeand all supporting infra. This simplifies our decorators and base class, and reduces the amount of state stored on an estimator. Since this was all private implementation details, this is not a breaking change.