Enable dice metric for UMAP and pairwise_distances #6842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
aamijar
added
non-breaking
aamijar
changed the title
aamijar
commented
Jun 4, 2025
| FORK rapidsai | ||
| PINNED_TAG branch-${CUML_BRANCH_VERSION_cuvs} | ||
| FORK aamijar | ||
| PINNED_TAG umap-dice-coefficient |
Member
Author
|
Blocked on constraints around cuvs binary size. |
Contributor
|
What's the plan for this PR? |
Member
Author
|
Currently this is a P2+ priority but basically, we need to refactor the cuvs side PR to avoid using cutlass which bloats the binary size. |
Contributor
Is there already a cuvs issue/PR for this? |
Member
Author
|
Yes rapidsai/cuvs#971, also in this PR description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5129
Depends on rapidsai/cuvs#971
Adding new distance types in cuvs bloats the binary size.