Fix data_alloc_size query bugs#21955
Merged
rapids-bot[bot] merged 7 commits intorapidsai:mainfrom Apr 1, 2026
Merged
Conversation
rjzamora
added
bug
github-actions
bot
added
Python
rjzamora
added
3 - Ready for Review
wence-
approved these changes
Mar 31, 2026
Comment on lines
+55
to
67
| chunk = chunk.make_available_and_spill( | ||
| self.context.br(), allow_overbooking=True | ||
| ) | ||
| self.allgather.insert( | ||
| sequence_number, | ||
| PackedData.from_cudf_packed_columns( | ||
| pack( | ||
| chunk.table_view(), | ||
| chunk.stream, | ||
| ), | ||
| chunk.stream, | ||
| self.context.br(), | ||
| ), |
Contributor
There was a problem hiding this comment.
Can you open an issue in rapidsmpf. If the table is already in packed form (e.g. either spilled or unspilled from packed), this does a copy for no reason.
Member
Author
There was a problem hiding this comment.
How about rapidsai/rapidsmpf#933 ? (feel free to correct/close that issue if I misunderstood your meaning here)
python/cudf_polars/cudf_polars/experimental/rapidsmpf/collectives/allgather.py
Show resolved
Hide resolved
rjzamora
added
5 - Ready to Merge
Member
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I think we want to avoid specifying
MemoryType.DEVICEwhen we query the allocation size of a TableChunk. The data may be in host or device memory, so we want to leave the argument empty. This PR also addresses a TODO statement related to un-spilling data to access the row-count.Checklist