Remove cudf::detail::target_type from groupby gtests#21932
Draft
davidwendt wants to merge 3 commits intorapidsai:mainfrom
Draft
Remove cudf::detail::target_type from groupby gtests#21932davidwendt wants to merge 3 commits intorapidsai:mainfrom
davidwendt wants to merge 3 commits intorapidsai:mainfrom
Conversation
davidwendt
added
3 - Ready for Review
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test |
3 tasks
Contributor
Author
|
/ok to test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces the
cudf::detail::target_typeusage from groupby and rolling tests. Using an internal utility to help test code logic that then uses that same utility seems like poor unit test form. The expected value types are easily computed and it would make sense if an expected output type has changed for an aggregation that tests are also updated (or fail if not updated).Checklist