Skip to content

Deduplicate parquet pass construction#21923

Merged
rapids-bot[bot] merged 27 commits intorapidsai:mainfrom
mhaseeb123:improve/dedup-pq-reader-passes
Apr 8, 2026
Merged

Deduplicate parquet pass construction#21923
rapids-bot[bot] merged 27 commits intorapidsai:mainfrom
mhaseeb123:improve/dedup-pq-reader-passes

Conversation

@mhaseeb123
Copy link
Copy Markdown
Member

@mhaseeb123 mhaseeb123 commented Mar 25, 2026

Description

Follow up #21895

This PR deduplicates parquet pass construction code across the main and hybrid scan parquet readers.

Checklist

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Mar 25, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the libcudf Affects libcudf (C++/CUDA) code. label Mar 25, 2026
@mhaseeb123 mhaseeb123 added 2 - In Progress Currently a work in progress improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Velox Functionality that helps Velox-cudf labels Mar 25, 2026
@mhaseeb123 mhaseeb123 removed the 2 - In Progress Currently a work in progress label Apr 3, 2026
@mhaseeb123 mhaseeb123 added the 3 - Ready for Review Ready for review by team label Apr 3, 2026
@mhaseeb123 mhaseeb123 marked this pull request as ready for review April 3, 2026 18:21
@mhaseeb123 mhaseeb123 requested a review from a team as a code owner April 3, 2026 18:21
@mhaseeb123 mhaseeb123 requested review from PointKernel and wence- April 3, 2026 18:21
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Apr 7, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

// if we have a split at this row count and this is the last instance of this row count
auto start = thrust::make_transform_iterator(splits->begin(),
[](row_range const& i) { return i.skip_rows; });
auto start = cuda::make_transform_iterator(splits->begin(),
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@mhaseeb123 mhaseeb123 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Apr 7, 2026
@mhaseeb123
Copy link
Copy Markdown
Member Author

/ok to test f8ee4d8

@mhaseeb123
Copy link
Copy Markdown
Member Author

/merge

@rapids-bot rapids-bot Bot merged commit 9055347 into rapidsai:main Apr 8, 2026
116 of 117 checks passed
@mhaseeb123 mhaseeb123 deleted the improve/dedup-pq-reader-passes branch April 8, 2026 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Velox Functionality that helps Velox-cudf

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants