Skip to content

Compatibility updates for CCCL 3.2 #20725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 26, 2025
Merged

Compatibility updates for CCCL 3.2 #20725

merged 7 commits into from
Nov 26, 2025
+87 −6

Conversation

@bdice
Copy link
Contributor

@bdice bdice commented Nov 25, 2025 •
edited
Loading

Description

The following minor changes are needed to make cuDF compile with CCCL 3.2.

  • Use cuda::std::distance in segmented_top_k.cu
  • Remove const qualifier from resource_ref
  • Vendor AliasTemporaries
  • Initialize ptx_version
  • Add nv_exec_check_disable to rmm_host_allocator

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice requested a review from a team as a code owner November 25, 2025 03:06
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Nov 25, 2025
@bdice bdice added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 25, 2025
@bdice bdice mentioned this pull request Nov 25, 2025
Draft
3 tasks
PointKernel
PointKernel reviewed Nov 25, 2025
View reviewed changes
PointKernel
PointKernel approved these changes Nov 25, 2025
View reviewed changes
Copy link
Member

@PointKernel PointKernel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

mhaseeb123
mhaseeb123 approved these changes Nov 25, 2025
View reviewed changes
cpp/src/io/fst/dispatch_dfa.cuh Outdated
size_t allocation_offsets[ALLOCATIONS];
size_t bytes_needed = 0;
for (int i = 0; i < ALLOCATIONS; ++i) {
const size_t allocation_bytes = (allocation_sizes[i] + ALIGN_BYTES - 1) & ALIGN_MASK;
Copy link
Member

@mhaseeb123 mhaseeb123 Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const size_t allocation_bytes = (allocation_sizes[i] + ALIGN_BYTES - 1) & ALIGN_MASK;
size_t const allocation_bytes = (allocation_sizes[i] + ALIGN_BYTES - 1) & ALIGN_MASK;

@bdice
Copy link
Contributor Author

bdice commented Nov 26, 2025

/merge

@rapids-bot rapids-bot bot merged commit 23d0d8c into rapidsai:main Nov 26, 2025
270 of 271 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PointKernel PointKernel PointKernel approved these changes

@mhaseeb123 mhaseeb123 mhaseeb123 approved these changes

@mythrocks mythrocks Awaiting requested review from mythrocks mythrocks is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@bdice bdice

Labels

improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bdice @PointKernel @mhaseeb123